Fix some defines in libs cmake #123576
Open
Fix some defines in libs cmake #123576
+6
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
am11
added
area-System.Runtime
and removed
needs-area-label
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-runtime |
am11
commented
Jan 24, 2026
| #cmakedefine01 HAVE_TERMIOS2 | ||
|
|
||
| #ifndef HOST_WASI | ||
| #cmakedefine01 HAVE_GETRUSAGE |
Member
Author
There was a problem hiding this comment.
#if HAVE_GETRUSAGE was always false; since there is no initialization in .cmake file.
#if defined(HAVE_GETRUSAGE) was always true; since it is defined (with value 0)..
Simply switched a single usage to use HOST_WASI based condition instead.
am11
commented
Jan 24, 2026
| check_symbol_exists( | ||
| strlcpy | ||
| string.h | ||
| HAVE_STRLCPY) |
Member
Author
There was a problem hiding this comment.
Was mistakenly removed in 5978738 but it is still used.
pavelsavara
reviewed
Jan 24, 2026
jkoritzinsky
approved these changes
Jan 24, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.