Skip to content

Fix some defines in libs cmake #123576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
am11 wants to merge 3 commits into
base: main
Choose a base branch
from
+6 −5
Open

Fix some defines in libs cmake #123576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
87765b6
Fix some defines in libs cmake
am11 Jan 24, 2026
d96fe54
Update pal_config.h.in
am11 Jan 24, 2026
a4cad19
Update
am11 Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/native/libs/Common/pal_config.h.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,10 +146,6 @@
#cmakedefine01 HAVE_GETGRGID_R
#cmakedefine01 HAVE_TERMIOS2

#ifndef HOST_WASI
#cmakedefine01 HAVE_GETRUSAGE
Copy link
Member Author

@am11 am11 Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#if HAVE_GETRUSAGE was always false; since there is no initialization in .cmake file.
#if defined(HAVE_GETRUSAGE) was always true; since it is defined (with value 0)..

Simply switched a single usage to use HOST_WASI based condition instead.

#endif

// Mac OS X has stat64, but it is deprecated since plain stat now
// provides the same 64-bit aware struct when targeting OS X > 10.5
// and not passing _DARWIN_NO_64_BIT_INODE.
Expand Down
2 changes: 1 addition & 1 deletion src/native/libs/System.Native/pal_time.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ int64_t SystemNative_GetBootTimeTicks(void)

double SystemNative_GetCpuUtilization(ProcessCpuInformation* previousCpuInfo)
{
#if defined(HAVE_GETRUSAGE)
#ifndef HOST_WASI
uint64_t kernelTime = 0;
uint64_t userTime = 0;

Expand Down
5 changes: 5 additions & 0 deletions src/native/libs/configure.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,11 @@ check_symbol_exists(
string.h
HAVE_STRCPY_S)

check_symbol_exists(
strlcpy
string.h
HAVE_STRLCPY)
Copy link
Member Author

@am11 am11 Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was mistakenly removed in 5978738 but it is still used.


check_symbol_exists(
strlcat
string.h
Expand Down
Loading