generated from nginx/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 1
Normalize CLA comment text to handle trailing punctuation #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
8
commits into
main
Choose a base branch
from
copilot/fix-cla-approval-period-issue
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nses Co-authored-by: alessfg <[email protected]>
Co-authored-by: alessfg <[email protected]>
Co-authored-by: alessfg <[email protected]>
…polation Co-authored-by: alessfg <[email protected]>
…ondition Co-authored-by: alessfg <[email protected]>
Co-authored-by: alessfg <[email protected]>
Co-authored-by: alessfg <[email protected]>
Copilot
AI
changed the title
[WIP] Fix CLA approval failure with period at end of sentence
Normalize CLA comment text to handle trailing punctuation
Nov 4, 2025
Copilot finished work on behalf of
alessfg
November 4, 2025 14:11
TasoOneAsia
reviewed
Nov 5, 2025
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic looked okay aside from one comment.
TasoOneAsia
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLA approvals were failing when users added trailing punctuation to their agreement comment (e.g.,
"I have hereby read the F5 CLA and agree to its terms."). The workflow used exact string matching which rejected natural variations.Changes
issue_commentevents to strip leading/trailing whitespace and trailing punctuation (.!?;,) before matchingpull_request_targetevents first, then normalized output forissue_commentevents (avoids accessing undefined step outputs)printfinstead of direct interpolation to prevent shell injectionImplementation
Backward compatible—comments without punctuation continue to work unchanged.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.