generated from nginx/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 1
Normalize CLA comment text to handle trailing punctuation #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
8
commits into
main
Choose a base branch
from
copilot/fix-cla-approval-period-issue
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
63cd12b
Initial plan
Copilot e63656c
Add comment normalization to handle trailing punctuation in CLA respo…
Copilot 7f91bd9
Update documentation to reflect comment normalization feature
Copilot 898c827
Fix workflow condition to handle pull_request_target events correctly
Copilot 2286912
Improve security by using env vars and printf instead of direct inter…
Copilot 602d283
Improve code readability with combined sed expression and multiline c…
Copilot a034ef9
Remove debug logging to avoid exposing user input in workflow logs
Copilot 9d28680
Fix trailing whitespace in conditional for consistency
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,9 @@ | ||
| # Unreleased | ||
|
|
||
| ## Changed | ||
|
|
||
| - Enhanced CLA workflow to handle trailing punctuation in user comments. The workflow now automatically normalizes comments by trimming whitespace and removing trailing punctuation marks (`.`, `!`, `?`, `;`, `,`), allowing users to naturally add punctuation to their CLA agreement statement without causing approval failures. | ||
|
|
||
| # Feb 6, 2025 | ||
|
|
||
| Initial release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.