Skip to content

Conversation

@mdimopoulos
Copy link
Contributor

  • created new AAC test suite generator gen_aac.py
  • tested to work with ISO_IEC_13818-4_2004 ADTS suite

@mdimopoulos mdimopoulos marked this pull request as ready for review November 13, 2024 17:27

[tool.setuptools.data-files]
"share/fluster/test_suites/aac" = [
"test_suites/aac/ISO_IEC_13818-4_2004.json",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change here will break BC, but it's necessary to differentiate against suites that we are going to add soon. I think that we can do a new fluster release before the end of the year where we can include all BC breaking code and inform the users in a CHANGELOG about it.
As discussed the other day.
@rsanchez87 @rgonzalezfluendo thoughts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% agree

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree 👍

Copy link
Contributor

@rsanchez87 rsanchez87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an exception when executing (python3 scripts/gen_aac.py):

Traceback (most recent call last):
  File "/home/rsanchez/SOFTWARE/fluster/scripts/gen_aac.py", line 330, in <module>
    generator.generate(not args.skip_download, args.jobs)
  File "/home/rsanchez/SOFTWARE/fluster/scripts/gen_aac.py", line 241, in generate
    raise Exception(f"Bitstream file {test_vector.input_file} not found in {dest_dir}")
Exception: Bitstream file al12_48.adts not found in resources/MPEG2_AAC-ADTS/al12_48

The reason why I'm launching from:

user: fluster$ python3 scripts/gen_aac.py

@mdimopoulos What do you think about not including the absolute path? (In the future we may have a CI and these commands will be executed from the root path of fluster...)

In the rest of ts, this is the way it is. In this branch from this one, it's working (COM-12460)

@mdimopoulos
Copy link
Contributor Author

mdimopoulos commented Nov 14, 2024

There is an exception when executing (python3 scripts/gen_aac.py):

Traceback (most recent call last):
  File "/home/rsanchez/SOFTWARE/fluster/scripts/gen_aac.py", line 330, in <module>
    generator.generate(not args.skip_download, args.jobs)
  File "/home/rsanchez/SOFTWARE/fluster/scripts/gen_aac.py", line 241, in generate
    raise Exception(f"Bitstream file {test_vector.input_file} not found in {dest_dir}")
Exception: Bitstream file al12_48.adts not found in resources/MPEG2_AAC-ADTS/al12_48

The reason why I'm launching from:

user: fluster$ python3 scripts/gen_aac.py

@mdimopoulos What do you think about not including the absolute path? (In the future we may have a CI and these commands will be executed from the root path of fluster...)

In the rest of ts, this is the way it is. In this branch from this one, it's working (COM-12460)

I have fixed this in the latest fixup commit.
In other test suites absolute_input_path is an absolute path. So for now i will leave it as is here too. In the future we can think about a refactoring of this logic in all generator scripts. It would be nice that all test suites are downloaded within a specific relative folder path always, independent of the current working directory. And we can also change absolute to relative paths by using the script's path at runtime (os.path.XYZ(__file__))

Copy link
Contributor

@rsanchez87 rsanchez87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mdimopoulos and others added 2 commits November 14, 2024 13:03
- created new AAC test suite generator gen_aac.py
- tested to work with ISO_IEC_13818-4_2004 ADTS suite
COM-12460-fix in mpeg4 reference decoder generation x32 to x64 bits and add mpeg2 reference decoder generation in Makefile
@mdimopoulos mdimopoulos merged commit 6ea228e into master Nov 14, 2024
3 checks passed
@mdimopoulos mdimopoulos deleted the COM-12461 branch November 14, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants