-
Notifications
You must be signed in to change notification settings - Fork 31
COM-12461: Create an AAC test suite generator #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mdimopoulos
commented
Nov 12, 2024
- created new AAC test suite generator gen_aac.py
- tested to work with ISO_IEC_13818-4_2004 ADTS suite
f8e3f11 to
d27cac4
Compare
|
|
||
| [tool.setuptools.data-files] | ||
| "share/fluster/test_suites/aac" = [ | ||
| "test_suites/aac/ISO_IEC_13818-4_2004.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change here will break BC, but it's necessary to differentiate against suites that we are going to add soon. I think that we can do a new fluster release before the end of the year where we can include all BC breaking code and inform the users in a CHANGELOG about it.
As discussed the other day.
@rsanchez87 @rgonzalezfluendo thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
100% agree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally agree 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an exception when executing (python3 scripts/gen_aac.py):
Traceback (most recent call last):
File "/home/rsanchez/SOFTWARE/fluster/scripts/gen_aac.py", line 330, in <module>
generator.generate(not args.skip_download, args.jobs)
File "/home/rsanchez/SOFTWARE/fluster/scripts/gen_aac.py", line 241, in generate
raise Exception(f"Bitstream file {test_vector.input_file} not found in {dest_dir}")
Exception: Bitstream file al12_48.adts not found in resources/MPEG2_AAC-ADTS/al12_48
The reason why I'm launching from:
user: fluster$ python3 scripts/gen_aac.py
@mdimopoulos What do you think about not including the absolute path? (In the future we may have a CI and these commands will be executed from the root path of fluster...)
In the rest of ts, this is the way it is. In this branch from this one, it's working (COM-12460)
I have fixed this in the latest fixup commit. |
rsanchez87
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
- created new AAC test suite generator gen_aac.py - tested to work with ISO_IEC_13818-4_2004 ADTS suite
COM-12460-fix in mpeg4 reference decoder generation x32 to x64 bits and add mpeg2 reference decoder generation in Makefile
1ede601 to
55ac8c0
Compare