-
Notifications
You must be signed in to change notification settings - Fork 31
COM-12461: Create an AAC test suite generator #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -55,3 +55,4 @@ class OutputFormat(Enum): | |
| GRAY12LE = "gray12le" | ||
| GRAY16LE = "gray16le" | ||
| UNKNOWN = "Unknown" | ||
| FLTP = "fltp" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| # Fluster - testing framework for decoders conformance | ||
| # Copyright (C) 2024, Fluendo, S.A. | ||
| # Author: Rubén Sánchez <[email protected]>, Fluendo, S.A. | ||
| # | ||
| # This library is free software; you can redistribute it and/or | ||
| # modify it under the terms of the GNU Lesser General Public License | ||
| # as published by the Free Software Foundation, either version 3 | ||
| # of the License, or (at your option) any later version. | ||
| # | ||
| # This library is distributed in the hope that it will be useful, | ||
| # but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
| # Lesser General Public License for more details. | ||
| # | ||
| # You should have received a copy of the GNU Lesser General Public | ||
| # License along with this library. If not, see <https://www.gnu.org/licenses/>. | ||
|
|
||
| from fluster.codec import Codec, OutputFormat | ||
| from fluster.decoder import Decoder, register_decoder | ||
| from fluster.utils import file_checksum, run_command | ||
|
|
||
|
|
||
| @register_decoder | ||
| class ISOAACDecoder(Decoder): | ||
| """ISO MPEG2 AAC reference decoder implementation""" | ||
|
|
||
| name = "ISO-MPEG2-AAC" | ||
| description = "ISO MPEG2 AAC reference decoder" | ||
| codec = Codec.AAC | ||
| binary = "aacdec_mc" | ||
|
|
||
| def decode( | ||
| self, | ||
| input_filepath: str, | ||
| output_filepath: str, | ||
| output_format: OutputFormat, | ||
| timeout: int, | ||
| verbose: bool, | ||
| keep_files: bool, | ||
| ) -> str: | ||
| """Decodes input_filepath in output_filepath""" | ||
| # pylint: disable=unused-argument | ||
| # Addition of .pcm as extension is a must. If it is something else, e.g. ".out" the decoder will output a | ||
| # ".wav", which is undesirable. | ||
| output_filepath += ".pcm" | ||
| run_command( | ||
| [self.binary, input_filepath, output_filepath], | ||
| timeout=timeout, | ||
| verbose=verbose, | ||
| ) | ||
| return file_checksum(output_filepath) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change here will break BC, but it's necessary to differentiate against suites that we are going to add soon. I think that we can do a new fluster release before the end of the year where we can include all BC breaking code and inform the users in a CHANGELOG about it.
As discussed the other day.
@rsanchez87 @rgonzalezfluendo thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
100% agree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally agree 👍