Fix: Resolve gRPC hostname parsing issue in OAuth connections #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressing an issue that clients have with non-browser OAuth flows. Fix NullPointerException when tenant URL lacks scheme Handle both URLs with schemes (https://hostname.com) and without (hostname.com) Add validation to ensure hostname is not null or empty before gRPC channel creation Add logging to help debug tenant URL parsing issues
|
Thanks for the contribution! Before we can merge this, we need @mtodat to sign the Salesforce Inc. Contributor License Agreement. |
vogelsgesang
approved these changes
Aug 12, 2025
Comment on lines
+149
to
+150
| val tenantUrl = tokenProcessor.getDataCloudToken().getTenantUrl(); | ||
| log.info("Creating gRPC channel for tenant URL: {}", tenantUrl); |
Contributor
There was a problem hiding this comment.
incorrect indentation. Please run the code formatter
Author
There was a problem hiding this comment.
WAHH! Github web edit!!! Now I need to set up my personal account in my git workflow after all
Contributor
There was a problem hiding this comment.
please provide a proper commit message, in particular also providing details in which context we get the prefixed URLs instead of just the host name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing an issue that clients have with non-browser OAuth flows.
Fix NullPointerException when tenant URL lacks scheme. Handle both URLs with schemes (
https://hostname.com) and without (hostname.com). Add validation to ensure hostname is not null or empty before gRPC channel creation. Add logging to help debug tenant URL parsing issues.