Skip to content

Fix: Resolve gRPC hostname parsing issue in OAuth connections #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Resolve gRPC hostname parsing issue in OAuth connections #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion jdbc/src/main/java/com/salesforce/datacloud/jdbc/DataCloudJDBCDriver.java
View file
Open in desktop
Copy link
Contributor

@vogelsgesang vogelsgesang Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please provide a proper commit message, in particular also providing details in which context we get the prefixed URLs instead of just the host name

Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,26 @@ static DataCloudConnection oauthBasedConnection(String url, Properties propertie
val tokenProcessor = getDataCloudTokenProcessor(properties);
val authInterceptor = TokenProcessorSupplier.of(tokenProcessor);

val host = tokenProcessor.getDataCloudToken().getTenantUrl();
val tenantUrl = tokenProcessor.getDataCloudToken().getTenantUrl();
log.info("Creating gRPC channel for tenant URL: {}", tenantUrl);
Comment on lines +149 to +150
Copy link
Contributor

@vogelsgesang vogelsgesang Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incorrect indentation. Please run the code formatter

Copy link
Author

@mtodat mtodat Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WAHH! Github web edit!!! Now I need to set up my personal account in my git workflow after all


// Extract hostname from tenant URL, handling both URLs with and without schemes
String host;
if (tenantUrl.contains("://")) {
// URL has a scheme, parse it normally
val tenantUri = java.net.URI.create(tenantUrl);
host = tenantUri.getHost();
} else {
// URL is just a hostname, use it directly
host = tenantUrl;
}
log.info("Extracted hostname from tenant URL: {}", host);

if (host == null || host.trim().isEmpty()) {
throw new DataCloudJDBCException(
String.format("Invalid tenant URL '%s': could not extract hostname", tenantUrl));
}

final ManagedChannelBuilder<?> builder = ManagedChannelBuilder.forAddress(
host, DataCloudConnection.DEFAULT_PORT)
.intercept(TracingHeadersInterceptor.of());
Expand Down