Update master to 3.3.0 #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to make the upcoming release a patch one. This partially reverts commit 2ee43de.
because it became aware of singleton classes.
We currently support the options '%-d', '%-H', '%-I', '%-M', '%-m', '%-S', but not '%-l'. Adding '%-l' will prevent an error to be raised when the Ruby format uses this option.
* fix is_blank and is_present filters for uuid columns * fix rubocop errors
* Use starts_with? Add specs * Fix linter issues * Fix linter issues. Disable metric ClassLength cop on config file. * Use base_url to check return_to param * Fix linter issues * Consider redirect to paths. Fix linter issues. * Address feedback --------- Co-authored-by: Steven Chau <[email protected]>
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/q > Most modern browsers implement this by surrounding the text in quotation marks. Importantly, this uses the localized quotation glyph. In English, this is the same left/right quotation mark.
- Setup CI - Load fontawesome files by using $fa-font-path
…ors (#3555) * Resolved a problem with embedded mongoid documents and boolean selectors Previous implementation was creating a label with an incorrect for attribute when used on an embedded mongoid document. It would create <label for=parent_class[embedded_class_attributes]_field_name_1 ... when the id of the input field was parent_class_embedded_class_attributes_field_name_1. Because of this the selectors did nothing when clicked since the label references an id that does not exist. This change to using the rails label helper should safely create the label in all cases. * Resolved a problem with embedded mongoid documents and boolean selectors Previous implementation was creating a label with an incorrect for attribute when used on an embedded mongoid document. It would create <label for=parent_class[embedded_class_attributes]_field_name_1 ... when the id of the input field was parent_class_embedded_class_attributes_field_name_1. Because of this the selectors did nothing when clicked since the label references an id that does not exist. This change to using the rails label helper should safely create the label in all cases. * Added spec for embedded booleans * reducing scope of JS enable to just the test that needs it
Reuse content column instead of adding a new boolean one, as modifying an old migration doesn't change existing databases
- Add a spec - Apply Prettier
…3656) * Show a thumbnail of all representable Active Storage files not only images * Fix RuboCop offense * Show representable and all images (incl. SVGs) * Fix RuboCop offense
- Do not abbreviate 'representation' - Add specs
* test against rails 8.0 * allow rails 8 * Require more recent version of sqlite for rails 8 * Upgrade required sqlite version to 2.2, fix json spec * Make sure the dummy uses sqlite3 2.2 as well * Only upgrade sqlite3 for rails 8 * Don't use the newer version of sqlite in the dummy app
- Fix Rails 7.0/7.1 builds - Remove spec/dummy_app/Gemfile.rails6, as it's not used much
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so we have Rails 8 compatability.