Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
85 commits
Select commit Hold shift + click to select a range
87c9d5b
Fix to show non-eager-loaded models which are explicitly configured
mshibuya Feb 24, 2023
aca22b6
Fix install failing with importmap setup
mshibuya Mar 22, 2023
33773d7
Postpone introduction of the new event name `rails_admin:dom_ready`
mshibuya Mar 23, 2023
5a958e4
Version 3.1.2
mshibuya Mar 23, 2023
dec5be4
Relax Rubocop Metrics/ClassLength threshold
mshibuya Jun 17, 2023
d7506e7
Fix webpacker build
mshibuya Jun 17, 2023
75a6927
Fix multiple_carrierwave field spec failing due to mocking
mshibuya Jun 17, 2023
2a89ebc
Fix polymorphic association target classes not set correctly in subcl…
mshibuya Jun 17, 2023
923d73e
Add support for '%-l' option to Flatpickr. (#3616)
gguerini Jun 17, 2023
647347c
fix is_blank and is_present filters for uuid columns (#3629)
ozenbusra Jun 17, 2023
f06df8f
Fix Rubocop offense
mshibuya Jul 1, 2023
da48004
Vulnerability fix: validate return_to param using request.host (#3627)
nicoayala Jul 1, 2023
d1859a8
Replace &rdquo; entity with inline <q> element (#3636)
jdufresne Jul 6, 2023
e158beb
Fix typo: tripple ==> triple (#3637)
jdufresne Jul 6, 2023
2379583
Unlock webrick version
mshibuya Jul 31, 2023
5ca8ccb
Revive the live demo
mshibuya Aug 6, 2023
6ab7bd3
Fix Rubocop offense
mshibuya Aug 13, 2023
12715f2
Support client-side dynamic scoping
mshibuya Aug 13, 2023
a8a2584
Basic vite integration attempt (#3643)
bankair Aug 20, 2023
0e12e5b
Follow-up for #3643
mshibuya Aug 20, 2023
13c90fd
Stop using update_only to decide to show subform on create (#3649)
myers Oct 28, 2023
8708722
Resolved a problem with embedded mongoid documents and boolean select…
rpalackas Nov 25, 2023
c042fe5
Follow-up for #3555
mshibuya Nov 25, 2023
c6c17d1
Un-pin turbo-rails to fix Rails 6.1 builds
mshibuya Nov 25, 2023
b78be36
Upgrade node and vite to fix the vite build
mshibuya Nov 25, 2023
68ad436
Mitigate jRuby build failures
mshibuya Nov 26, 2023
9a50b9e
Test against Rails 7.1
mshibuya Nov 27, 2023
cb2edd3
Test against Mongoid 8
mshibuya Nov 28, 2023
5beaf7c
Bump jRuby
mshibuya Nov 28, 2023
5c21878
Tidy up gemfiles
mshibuya Nov 28, 2023
073b809
Make ActiveStorage/ActionText detection less likely to cause false po…
mshibuya Jan 7, 2024
24380d5
Support importmap-rails 2.0
mshibuya Jan 7, 2024
0f29ea8
Test against Ruby 3.3
mshibuya Jan 7, 2024
a31e6d5
Satisfy Rubocop
mshibuya Jan 7, 2024
af7414a
Avoid factory_bot 6.4.5
mshibuya Jan 7, 2024
d520219
Allow turbo-rails 2 in gemspec (#3671)
bb Feb 12, 2024
c6a4036
Fix the build
mshibuya Feb 12, 2024
b8155f8
Quote table_ and column_name for sorting (#3652)
rnestler Feb 26, 2024
9ecfa42
Fix default config path for ImportmapFormatter (#3676)
rnestler Mar 1, 2024
d1ae021
Follow-up for #3652
mshibuya Mar 2, 2024
51d4539
Temporarily lock jRuby to 9.4.5.0
mshibuya Mar 2, 2024
96a0f66
Use released versions of turbo-rails
mshibuya Mar 2, 2024
06c9f5c
Correct meta tags syntax (#3672)
coorasse Mar 2, 2024
5d1582d
Fix Rubocop offense
mshibuya May 18, 2024
c23bc98
Pin sqlite3 to 1.x, as ActiveRecord is not compatible yet
mshibuya May 18, 2024
4e9366f
Fix incompatibility with bson gem 5.0.0
mshibuya May 19, 2024
dba6c4b
Fix error on searching or sorting by ActiveStorage field
mshibuya May 18, 2024
86d8000
Bump CI action versions to reduce Node.js 16 actions deprecation warning
mshibuya May 19, 2024
f1cec36
Lock cancancan to 3.5.x as 3.6 doesn't work in Ruby 2.6
mshibuya Jun 2, 2024
d62f604
Fix enum filter breaking when pre-populated
mshibuya Jun 8, 2024
91737ab
Handle has_one assignment on the field level, making patched has_one …
mshibuya Jun 2, 2024
6399cd9
Fix some typos (#3688)
jdufresne Jun 14, 2024
b9e8161
Tidy up trailing whitespace in gem post_install_message (#3689)
jdufresne Jun 16, 2024
9538f93
Avoid cuprite 0.15.1 to work around JRuby CI failure
mshibuya Jun 16, 2024
a3eac8c
Unlock JRuby version
mshibuya Jun 16, 2024
4e7bd09
Use require_relative to avoid modifying $LOAD_PATH in gemspec (#3690)
jdufresne Jun 17, 2024
32f91e4
Fix XSS vulnerability in the list view
mshibuya Jul 6, 2024
e3e9e8c
Fix 32f91e4 broke fields with HTML tags
mshibuya Jul 9, 2024
34c5fec
Version 3.2.0.beta
mshibuya Jul 13, 2024
afee74e
Remove unused code in Dragonfly field
mshibuya Jul 14, 2024
31e164a
Fix issues in running specs locally
mshibuya Jul 28, 2024
d20b024
Use coverallsapp/github-action@v2 to eliminate Node 16 deprecation wa…
mshibuya Jul 28, 2024
876be11
Introduce SingularAssociation and CollectionAssociation to tidy up th…
mshibuya Jun 17, 2024
5245d5b
Lock jQuery UI version due to API removal in 1.14
mshibuya Aug 18, 2024
53b89c9
ActiveRecord 7.1 composite primary keys support
mshibuya Jun 16, 2024
9ea46b1
Test against Rails 7.2
mshibuya Aug 23, 2024
b666c63
Reset polymorphic id upon type change (#3630)
KMinChrist Aug 25, 2024
13114e5
Follow-up for #3630
mshibuya Aug 25, 2024
35c8702
Detect images properly in FileUpload and MultipleFileUpload field
mshibuya Aug 25, 2024
4417efc
Show a thumbnail of all representable Active Storage files + images (…
wvengen Aug 25, 2024
7754ac3
Follow-up for #3656
mshibuya Aug 25, 2024
7455d26
Version 3.2.0.rc
mshibuya Aug 25, 2024
c0eac2a
Importmap build no longer fails, as new npm package was released
mshibuya Aug 31, 2024
7b2ffb1
Fix polymorphic id doesn't reset properly in an edge case
mshibuya Sep 1, 2024
b4fdd67
Version 3.2.0
mshibuya Sep 8, 2024
195ef0b
Unlock vite/vite-plugin-ruby dependency to fix the vite build
mshibuya Sep 14, 2024
10bf495
Add specs for non-nullable boolean field
mshibuya Sep 21, 2024
586db0c
Avoid turbo-rails versions that are incompatible with Ruby 2.6
mshibuya Sep 21, 2024
ca232e7
Avoid newer turbo-rails for Ruby 2.6 build
mshibuya Oct 6, 2024
44579f0
Install ImageMagick as it's no longer included in 24.04 image
mshibuya Oct 6, 2024
f54a102
Disable Turbo's prefetch, which became default in turbo-rails 2.x
mshibuya Oct 6, 2024
b09f770
Version 3.2.1
mshibuya Oct 10, 2024
5412857
Test against rails 8.0 (#3702)
jewilmeer Nov 23, 2024
e38c12d
Follow-up for #3702
mshibuya Nov 23, 2024
f4cf4b6
Version 3.3.0
mshibuya Dec 8, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 54 additions & 25 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ jobs:
- "3.0"
- "3.1"
- "3.2"
gemfile: [gemfiles/rails_7.0.gemfile]
- "3.3"
gemfile: [gemfiles/rails_7.1.gemfile]
orm: [active_record]
adapter: [sqlite3]
asset: [webpack]
Expand All @@ -32,17 +33,37 @@ jobs:
orm: active_record
adapter: sqlite3
asset: webpacker
- ruby: "3.0"
- ruby: "3.2"
gemfile: gemfiles/rails_7.0.gemfile
orm: active_record
adapter: sqlite3
asset: sprockets
- ruby: "3.2"
gemfile: gemfiles/rails_7.1.gemfile
orm: active_record
adapter: mysql2
asset: importmap
- ruby: "3.0"
gemfile: gemfiles/rails_7.0.gemfile
- ruby: "3.2"
gemfile: gemfiles/rails_7.1.gemfile
orm: active_record
adapter: postgresql
asset: sprockets
- ruby: "3.0"
- ruby: "3.2"
gemfile: gemfiles/rails_7.1.gemfile
orm: active_record
adapter: sqlite3
asset: vite
- ruby: "3.3"
gemfile: gemfiles/rails_7.2.gemfile
orm: active_record
adapter: sqlite3
asset: sprockets
- ruby: "3.3"
gemfile: gemfiles/rails_8.0.gemfile
orm: active_record
adapter: sqlite3
asset: sprockets
- ruby: "3.2"
gemfile: gemfiles/composite_primary_keys.gemfile
orm: active_record
adapter: sqlite3
Expand All @@ -57,13 +78,23 @@ jobs:
orm: mongoid
adapter: sqlite3
asset: sprockets
- ruby: jruby-9.3
gemfile: gemfiles/rails_6.1.gemfile
- ruby: "3.1"
gemfile: gemfiles/rails_7.0.gemfile
orm: mongoid
adapter: sqlite3
asset: sprockets
- ruby: "3.2"
gemfile: gemfiles/rails_7.1.gemfile
orm: mongoid
adapter: sqlite3
asset: sprockets
- ruby: jruby-9.4
gemfile: gemfiles/rails_7.0.gemfile
orm: active_record
adapter: mysql2
asset: sprockets
- ruby: jruby-9.3
gemfile: gemfiles/rails_6.1.gemfile
- ruby: jruby-9.4
gemfile: gemfiles/rails_7.0.gemfile
orm: mongoid
adapter: sqlite3
asset: sprockets
Expand Down Expand Up @@ -93,7 +124,7 @@ jobs:
CI_ASSET: ${{ matrix.asset }}
JRUBY_OPTS: --debug
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
Expand All @@ -104,15 +135,18 @@ jobs:
MAKEFLAGS: make --jobs 4
BUNDLE_WITHOUT: development
- name: Set up Node
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: "14"
node-version: "18"
- name: Install ImageMagick
run: sudo apt-get install imagemagick
- name: Setup application
env:
BUNDLE_GEMFILE: ../../${{ matrix.gemfile }}
CI_ASSET: ${{ matrix.asset }}
CI_DB_ADAPTER: ${{ matrix.adapter }}
RAILS_ENV: test
NODE_OPTIONS: --openssl-legacy-provider
run: |
yarn install
cd spec/dummy_app
Expand All @@ -127,7 +161,7 @@ jobs:
run: bundle exec rspec
- name: Coveralls Parallel
if: ${{ github.repository_owner == 'railsadminteam' }}
uses: coverallsapp/github-action@master
uses: coverallsapp/github-action@v2
continue-on-error: true
with:
github-token: ${{ secrets.github_token }}
Expand All @@ -141,7 +175,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Coveralls Finished
uses: coverallsapp/github-action@master
uses: coverallsapp/github-action@v2
with:
github-token: ${{ secrets.github_token }}
parallel-finished: true
Expand All @@ -150,9 +184,9 @@ jobs:
name: Prettier
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Set up Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
- name: Install dependencies
run: yarn install
- name: Run check
Expand All @@ -162,18 +196,13 @@ jobs:
name: RuboCop
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: "3.0"
- name: Cache gems
uses: actions/cache@v3
with:
path: vendor/bundle
key: ${{ runner.os }}-gems-${{ matrix.ruby }}-${{ hashFiles('Gemfile') }}
restore-keys: |
${{ runner.os }}-gems-${{ matrix.ruby }}-
ruby-version: "3.2"
bundler-cache: true
cache-version: gems-${{ hashFiles('Gemfile') }}
- name: Install dependencies
run: bundle install --without development --jobs=3 --retry=3 --path=vendor/bundle
- name: Run check
Expand Down
6 changes: 5 additions & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ AllCops:
- "node_modules/**/*"
- "spec/dummy_app/bin/**/*"
- "spec/dummy_app/db/schema.rb"
- "spec/dummy_app/node_modules/**/*"
- "spec/dummy_app/tmp/**/*"
- "vendor/bundle/**/*"
NewCops: disable
Expand Down Expand Up @@ -108,7 +109,7 @@ Metrics/BlockNesting:

Metrics/ClassLength:
CountComments: false
Max: 132 # TODO: Lower to 100
Max: 201 # TODO: Lower to 100

Metrics/CyclomaticComplexity:
Max: 15 # TODO: Lower to 6
Expand Down Expand Up @@ -201,6 +202,9 @@ Style/RaiseArgs:
Style/RedundantArgument:
Enabled: true

Style/RedundantParentheses:
Enabled: false

Style/RedundantSelfAssignmentBranch:
Enabled: true

Expand Down
2 changes: 1 addition & 1 deletion .rubocop_todo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Lint/ReturnInVoidContext:
# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
# IgnoredMethods: refine
Metrics/BlockLength:
Max: 1097
Max: 1135

# Offense count: 1
# Configuration parameters: Max, CountKeywordArgs.
Expand Down
110 changes: 63 additions & 47 deletions Appraisals
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,15 @@

appraise 'rails-6.0' do
gem 'rails', '~> 6.0.0'
gem 'sassc-rails', '~> 2.1'
gem 'devise', '~> 4.7'
gem 'psych', '~> 3.3'
gem 'turbo-rails', '< 2.0.8'

group :test do
gem 'cancancan', '~> 3.0'
gem 'kt-paperclip'
gem 'cancancan', ['~> 3.0', '< 3.6']
gem 'pundit', '~> 2.1.0'
gem 'rspec-rails', '>= 4.0.0.beta2'
gem 'shrine', '~> 3.0'
end

group :active_record do
gem 'pg', '>= 1.0.0', platforms: :ruby
gem 'paper_trail', '>= 12.0'

platforms :jruby do
gem 'activerecord-jdbcmysql-adapter', '~> 60.0'
gem 'activerecord-jdbcpostgresql-adapter', '~> 60.0'
Expand All @@ -25,32 +19,20 @@ appraise 'rails-6.0' do
end

group :mongoid do
gem 'mongoid', '~> 7.0'
gem 'cancancan-mongoid'
gem 'carrierwave-mongoid', '>= 0.6.3', require: 'carrierwave/mongoid'
gem 'database_cleaner-mongoid', '>= 2.0', require: false
gem 'kaminari-mongoid'
gem 'mongoid', '~> 7.0'
gem 'mongoid-paperclip', '>= 0.0.8', require: 'mongoid_paperclip'
gem 'carrierwave-mongoid', '>= 0.6.3', require: 'carrierwave/mongoid'
gem 'cancancan-mongoid'
gem 'shrine-mongoid', '~> 1.0'
end
end

appraise 'rails-6.1' do
gem 'rails', '~> 6.1.0'
gem 'sassc-rails', '~> 2.1'
gem 'devise', '~> 4.7'
gem 'turbo-rails', platform: :jruby, github: 'hotwired/turbo-rails'

group :test do
gem 'cancancan', '~> 3.2'
gem 'kt-paperclip'
gem 'rspec-rails', '>= 4.0.0.beta2'
gem 'shrine', '~> 3.0'
end

group :active_record do
gem 'pg', '>= 1.0.0', platforms: :ruby
gem 'paper_trail', '>= 12.0'

platforms :jruby do
gem 'activerecord-jdbcmysql-adapter', '~> 61.0'
gem 'activerecord-jdbcpostgresql-adapter', '~> 61.0'
Expand All @@ -59,48 +41,82 @@ appraise 'rails-6.1' do
end

group :mongoid do
gem 'mongoid', '~> 7.0'
gem 'cancancan-mongoid'
gem 'carrierwave-mongoid', '>= 0.6.3', require: 'carrierwave/mongoid'
gem 'database_cleaner-mongoid', '>= 2.0', require: false
gem 'kaminari-mongoid'
gem 'mongoid', '~> 7.0'
gem 'mongoid-paperclip', '>= 0.0.8', require: 'mongoid_paperclip'
gem 'carrierwave-mongoid', '>= 0.6.3', require: 'carrierwave/mongoid'
gem 'cancancan-mongoid'
gem 'shrine-mongoid', '~> 1.0'
end
end

appraise 'rails-7.0' do
gem 'rails', '~> 7.0.0'
gem 'importmap-rails', require: false
gem 'sassc-rails', '~> 2.1'
gem 'devise', '~> 4.8'

group :test do
gem 'cancancan', '~> 3.2'
gem 'kt-paperclip'
gem 'rspec-rails', '>= 4.0.0.beta2'
gem 'shrine', '~> 3.0'
group :active_record do
platforms :ruby, :mswin, :mingw, :x64_mingw do
gem 'sqlite3', '~> 1.3'
end

platforms :jruby do
gem 'activerecord-jdbcmysql-adapter', '~> 70.0'
gem 'activerecord-jdbcpostgresql-adapter', '~> 70.0'
gem 'activerecord-jdbcsqlite3-adapter', '~> 70.0'
end
end

group :mongoid do
gem 'cancancan-mongoid'
gem 'carrierwave-mongoid', '>= 0.6.3', require: 'carrierwave/mongoid'
gem 'database_cleaner-mongoid', '>= 2.0', require: false
gem 'kaminari-mongoid'
gem 'mongoid', '~> 8.0'
gem 'mongoid-paperclip', '>= 0.0.8', require: 'mongoid_paperclip'
gem 'shrine-mongoid', '~> 1.0'
end
end

appraise 'rails-7.1' do
gem 'rails', '~> 7.1.0'
gem 'importmap-rails', require: false

group :active_record do
gem 'pg', '>= 1.0.0', platforms: :ruby
gem 'paper_trail', '>= 12.0'
platforms :ruby, :mswin, :mingw, :x64_mingw do
gem 'sqlite3', '~> 1.3'
end
end

group :mongoid do
gem 'cancancan-mongoid'
gem 'carrierwave-mongoid', '>= 0.6.3', require: 'carrierwave/mongoid'
gem 'database_cleaner-mongoid', '>= 2.0', require: false
gem 'kaminari-mongoid'
gem 'mongoid', '~> 8.0'
gem 'mongoid-paperclip', '>= 0.0.8', require: 'mongoid_paperclip'
gem 'shrine-mongoid', '~> 1.0'
end
end

appraise 'rails-7.2' do
gem 'rails', '~> 7.2.0'
gem 'importmap-rails', require: false
end

appraise 'rails-8.0' do
gem 'rails', '~> 8.0.0'
gem 'importmap-rails', require: false
end

appraise 'composite_primary_keys' do
gem 'rails', '~> 7.0.0'
gem 'sassc-rails', '~> 2.1'
gem 'devise', '~> 4.8'

group :test do
gem 'cancancan', '~> 3.2'
gem 'kt-paperclip'
gem 'rspec-rails', '>= 4.0.0.beta2'
gem 'shrine', '~> 3.0'
end

group :active_record do
gem 'composite_primary_keys'
gem 'paper_trail', '>= 12.0'

platforms :ruby, :mswin, :mingw, :x64_mingw do
gem 'sqlite3', '~> 1.3'
end
end
end
Loading
Loading