IBX-10902: Disabled negative numbers inside Badge component #68
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures that the Badge component only displays non-negative values by normalizing any negative input to zero. This change prevents badges from showing negative numbers, which would be semantically incorrect for this UI component.
Key Changes:
- Added normalization to the
valueproperty in the Badge component to clamp negative values to 0
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ->allowedTypes('int') | ||
| ->required(); | ||
| ->required() | ||
| ->normalize(static fn(OptionsResolver $options, int $value): int => max(0, $value)); |
There was a problem hiding this comment.
The normalization silently converts negative values to 0, which may hide bugs in calling code. Consider adding validation to reject negative values with a clear error message, or document this behavior explicitly if silent normalization is intentional.
Suggested change
| ->normalize(static fn(OptionsResolver $options, int $value): int => max(0, $value)); | |
| ->allowedValues(static fn(int $value): bool => $value >= 0); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
For QA:
Documentation: