Skip to content

IBX-10902: Disabled negative numbers inside Badge component #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
albozek wants to merge 1 commit into from
Closed

IBX-10902: Disabled negative numbers inside Badge component #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/lib/Twig/Components/Badge.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?php

Check warning on line 1 in src/lib/Twig/Components/Badge.php

View workflow job for this annotation

GitHub Actions / Run code style check (8.3) 

Found violation(s) of type: function_declaration

/**
* @copyright Copyright (C) Ibexa AS. All rights reserved.
Expand Down Expand Up @@ -51,7 +51,8 @@
$resolver
->define('value')
->allowedTypes('int')
->required();
->required()
->normalize(static fn(OptionsResolver $options, int $value): int => max(0, $value));
Copy link

Copilot AI Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The normalization silently converts negative values to 0, which may hide bugs in calling code. Consider adding validation to reject negative values with a clear error message, or document this behavior explicitly if silent normalization is intentional.

Suggested change
->normalize(static fn(OptionsResolver $options, int $value): int => max(0, $value));
->allowedValues(static fn(int $value): bool => $value >= 0);

Copilot uses AI. Check for mistakes.
$resolver
->define('maxBadgeValue')
->allowedTypes('int')
Expand Down
Loading