[Fusilli] Added ASM emitter for Layernorm node #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-sidorova
force-pushed
the
feature/layer_norm/asm
branch
3 times, most recently
from
e32ce84 to
aa92aca
Compare
4 tasks
a-sidorova
force-pushed
the
feature/layer_norm/asm
branch
from
aa92aca to
482a7b5
Compare
Signed-off-by: Alexandra Sidorova <[email protected]> [Fusilli] Removed epsilon from the node signature Signed-off-by: Alexandra Sidorova <[email protected]>
a-sidorova
force-pushed
the
feature/layer_norm/asm
branch
2 times, most recently
from
24c7cec to
2b09f3c
Compare
Signed-off-by: Alexandra Sidorova <[email protected]>
IanWood1
reviewed
Jan 9, 2026
Comment on lines
+245
to
+253
| // Scalar constants are inlined in the IR and not passed as function | ||
| // arguments, so they should not be in the variantPack. | ||
| if (input->isScalar()) { | ||
| FUSILLI_RETURN_ERROR_IF(variantPack.contains(input), | ||
| ErrorCode::VariantPackError, | ||
| "Scalar constant tensor found in variantPack"); | ||
| continue; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Is this true for all scalars? This seems to be the case for epsilon based on Cudnn's layer norm sample.
For example, if you have a pointwise multiply X * s where s is a scalar value. This would have to be passed in through the variant pack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The third part of #45