Skip to content

Conversation

@kinyoklion
Copy link
Member

@kinyoklion kinyoklion commented Oct 6, 2025

BEGIN_COMMIT_OVERRIDE
feat: Add configuration to allow adjusting the batch and queue sizes for logs and spans.
feat: Adjust the default export and queue batch sizes for logs and spans to match the otel defaults.
END_COMMIT_OVERRIDE

Summary

Adds the ability to configure the max queue size and export batch size for logs and traces.


Note

Adds configurable max export batch sizes and queue sizes for spans and logs, sets sensible defaults, and propagates them through initialization to OTLP providers.

  • Configuration:
    • Add fields to observabilityConfig for spanMaxExportBatchSize, spanMaxQueueSize, logMaxExportBatchSize, logMaxQueueSize with defaults (spans from sdktrace defaults; logs via copied constants).
    • New options: WithSpanMaxExportBatchSize, WithSpanMaxQueueSize, WithLogMaxExportBatchSize, WithLogMaxQueueSize.
  • Initialization:
    • Pass new sizing configs via otel.SetConfig in go/initialize.go.
  • OTEL Integration:
    • Extend internal/otel.Config with corresponding fields.
    • Use these values in tracer/log batch processors instead of hardcoded sizes.
  • Tests:
    • Add go/config_test.go covering defaults and option setters.

Written by Cursor Bugbot for commit b4a5d50. This will update automatically on new commits. Configure here.

@kinyoklion kinyoklion force-pushed the rlamb/go-tunable-memory branch from fb81dab to a5dfc4b Compare October 6, 2025 23:23
@kinyoklion kinyoklion force-pushed the rlamb/go-tunable-memory branch from a5dfc4b to be445b4 Compare October 6, 2025 23:28
@kinyoklion kinyoklion marked this pull request as ready for review October 6, 2025 23:32
@kinyoklion kinyoklion requested a review from a team as a code owner October 6, 2025 23:32
cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

@Vadman97 Vadman97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending the cursor-reported bug

cursor[bot]

This comment was marked as outdated.

@kinyoklion kinyoklion force-pushed the rlamb/go-tunable-memory branch from f84d7c9 to b4a5d50 Compare October 7, 2025 15:57
@kinyoklion kinyoklion merged commit abecbb6 into main Oct 7, 2025
22 checks passed
@kinyoklion kinyoklion deleted the rlamb/go-tunable-memory branch October 7, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants