Skip to content

Conversation

@euprunin
Copy link
Collaborator

@euprunin euprunin commented Dec 7, 2025


Trace profiling results (shown if β‰₯10 ms before or after):

  • StarMemClass.star_coe_eq: <10 ms before, <10 ms after πŸŽ‰
  • Set.MapsTo.iterate_restrict: 15 ms before, <10 ms after πŸŽ‰
  • Fintype.IsSimpleOrder.univ: <10 ms before, 14 ms after
  • Set.Iic_ciInf: 12 ms before, 19 ms after
  • coe_primesOverFinset: 47 ms before, 13 ms after πŸŽ‰

This golfing PR is batched under the following guidelines:

  • Up to ~5 changed files per PR
  • Up to ~25 changed declarations per PR
  • Up to ~100 changed lines per PR

Open in Gitpod

@github-actions
Copy link

github-actions bot commented Dec 7, 2025

PR summary c674151585

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! πŸ™

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks πŸŽ‰

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Dec 8, 2025
mathlib-bors bot pushed a commit that referenced this pull request Dec 8, 2025
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 8, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: golf using ext; simpa [Merged by Bors] - chore: golf using ext; simpa Dec 8, 2025
@mathlib-bors mathlib-bors bot closed this Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants