Skip to content

Conversation

@minad
Copy link
Member

@minad minad commented Oct 16, 2019

Supersedes #327. This removes all the deprecated functions. The empty file is removed in a separate commit, since we might want to keep it (or revert it) in the future if new deprecations come up.

@minad minad added this to the v2.0.0 milestone Oct 16, 2019
@minad minad changed the title Remove deprecated Remove deprecated functions Oct 16, 2019
@minad minad force-pushed the remove-deprecated branch from c5e4f5f to 6dc87ce Compare October 16, 2019 07:45
@minad minad added the finished label Oct 16, 2019
@minad minad requested a review from sjaeckel October 16, 2019 08:05
@minad minad force-pushed the remove-deprecated branch from 6dc87ce to b664cd5 Compare October 16, 2019 08:34
@minad minad force-pushed the remove-deprecated branch from b664cd5 to 0a53d29 Compare October 16, 2019 12:44
@minad
Copy link
Member Author

minad commented Oct 16, 2019

@sjaeckel Note that the more intrusive 8 bit removal is not done here. It is still in #349.

@minad minad force-pushed the remove-deprecated branch from 0a53d29 to 255f924 Compare October 17, 2019 15:03
@minad minad force-pushed the remove-deprecated branch from 255f924 to 20dcc92 Compare October 17, 2019 15:07
@nijtmans nijtmans self-requested a review October 18, 2019 07:29
@nijtmans
Copy link
Collaborator

Removal of the deprecated functions from tommath.def was still missing. Therefore my additional commit doing that. Looks good!

@minad
Copy link
Member Author

minad commented Oct 18, 2019

@nijtmans Thanks again! I saw those but then I forgot.

@sjaeckel sjaeckel merged commit b071413 into develop Oct 19, 2019
@sjaeckel sjaeckel deleted the remove-deprecated branch October 19, 2019 10:24
@sjaeckel sjaeckel removed the finished label Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants