[CIR] Add syncscope support for atomic load operations #1958
+148
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiang1997
requested review from
andykaylor,
bcardosolopes,
lanza and
xlauko
as code owners
jiang1997
force-pushed
the
fix-#1868
branch
2 times, most recently
from
5b25f33 to
af464b6
Compare
xlauko
reviewed
Nov 4, 2025
Comment on lines
690
to
695
| UnitAttr:$is_nontemporal, | ||
| OptionalAttr<I64Attr>:$alignment, | ||
| OptionalAttr<CIR_MemOrder>:$mem_order, | ||
| OptionalAttr<CIR_AnyTBAAAttr>:$tbaa | ||
| OptionalAttr<I64Attr>:$alignment, | ||
| OptionalAttr<CIR_MemScopeKind>:$syncscope, | ||
| OptionalAttr<CIR_MemOrder>:$mem_order, | ||
| OptionalAttr<CIR_AnyTBAAAttr>:$tbaa | ||
| ); |
There was a problem hiding this comment.
fix the indent and remove break line
xlauko
reviewed
Nov 4, 2025
| OptionalAttr<CIR_MemOrder>:$mem_order, | ||
| OptionalAttr<CIR_AnyTBAAAttr>:$tbaa | ||
| OptionalAttr<I64Attr>:$alignment, | ||
| OptionalAttr<CIR_MemScopeKind>:$syncscope, |
There was a problem hiding this comment.
Also rename to sync_scope to have more standard name and mirror what clang and llvm does.
xlauko
reviewed
Nov 4, 2025
Comment on lines
540
to
543
| def CIR_MemScopeKind : CIR_I32EnumAttr<"MemScopeKind", "memory scope kind", [ | ||
| I32EnumAttrCase<"SingleThread", 0, "single_thread">, | ||
| I32EnumAttrCase<"System", 1, "system"> | ||
| ]>; |
There was a problem hiding this comment.
Why not call it CIR_SyncScopeKind to be same as clang and llvm?
There was a problem hiding this comment.
We use sync_scope anyway in ops then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1868