Bugfix amrfm 2574 teb speed limits #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonynajjar
reviewed
Jul 11, 2022
There was a problem hiding this comment.
teb_config.h also has the same bug where:
robot.base_max_vel_x_backwards = robot.base_max_vel_x_backwards;
I will add to this PR
This is the PR where these were introduced: https://github.com/rst-tu-dortmund/teb_local_planner/pull/274/files#
|
totally agree, being able to configure both leads to this confusion |
tonynajjar
force-pushed
the
bugfix_AMRFM-2574_teb_speed_limits
branch
from
1e47bf9 to
401ade6
Compare
tonynajjar
force-pushed
the
bugfix_AMRFM-2574_teb_speed_limits
branch
from
401ade6 to
c810c90
Compare
tonynajjar
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not sure if this fixes the bug in all cases, but I can't see why these base velocities should be modified