Plug demuxing engine into HLS Client #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
varsill
requested changes
Jul 3, 2025
mix.exs
Outdated
Comment on lines
40
to
41
| # {:ex_m3u8, "~> 0.15.1"}, | ||
| {:ex_m3u8, github: "membraneframework/ex_m3u8", branch: "allow-empty-default"}, |
Collaborator
There was a problem hiding this comment.
remember to bump ex_m3u8 to v0.15.2
FelonEkonom
force-pushed
the
plug-demuxing-engine-into-client
branch
from
047d0d8 to
85968c2
Compare
FelonEkonom
force-pushed
the
plug-demuxing-engine-into-client
branch
from
85968c2 to
f467bda
Compare
FelonEkonom
force-pushed
the
plug-demuxing-engine-into-client
branch
from
c3a84d0 to
8de4292
Compare
varsill
reviewed
Jul 10, 2025
| {:membrane_h26x_plugin, "~> 0.10.2"}, | ||
| {:mpeg_ts, github: "kim-company/kim_mpeg_ts"}, | ||
| # {:mpeg_ts, github: "kim-company/kim_mpeg_ts"}, | ||
| {:mpeg_ts, github: "membraneframework-labs/kim_mpeg_ts", branch: "backport-v1.0.3"}, |
Collaborator
There was a problem hiding this comment.
remember to change the dependency
lib/ex_hls/client.ex
Outdated
|
|
||
| @opaque client :: map() | ||
| @type frame :: any() | ||
| @type sample :: any() |
Collaborator
There was a problem hiding this comment.
Let's leave name frame but let's also think about making sure these frames are aligned
FelonEkonom
force-pushed
the
plug-demuxing-engine-into-client
branch
from
204d8a7 to
076b2ad
Compare
varsill
approved these changes
Jul 16, 2025
Collaborator
varsill
left a comment
varsill
left a comment
There was a problem hiding this comment.
In the final version it would be good to have frame instead of a chunk, but it requires unifying how demuxers handle misalignment, so as of now: 🥇
(Just remember to create an issue about handling misalignment ;) )
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.