Skip to content

Conversation

@ananyashreesharma
Copy link
Contributor

@ananyashreesharma ananyashreesharma commented Oct 23, 2025

🧾 Tickets

📝 Description

When New Tab is set to Custom, dragging the suggestions list hides the keyboard and unintentionally cancels URL bar editing, which closes the suggestions abruptly
This change skips the keyboard hide auto cancel while suggestions are visible aligning behaviour with Firefox Home/Blank.

Before

issue.mp4

After

fix.mp4

Test plan

  • Setup:
    • Settings → General → New Tab → Custom, URL: https://www.google.com
    • Address bar position: verify both Top and Bottom
  • Custom New Tab
    • Type “fir”; drag/bounce suggestions → suggestions stays
    • Tap Cancel while dragging → overlay closes.
    • Tap a suggestion → loads and overlay closes.
    • Press Return → submits and closes.
    • Rotate mid-scroll; start/stop dictation → no unintended dismiss.
  • Firefox Home & Blank: drag keeps suggestions; Cancel still dismisses.
  • Private: unchanged (no suggestions until turned on manually)

✅ Checklist

  • I filled in the ticket numbers and a description of my work

  • I updated the PR name to follow our PR naming guidelines

  • I ensured unit tests pass and wrote tests for new code

  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)

  • If adding telemetry, I read the data stewardship requirements and will request a data review

  • If adding or modifying strings, I read the guidelines and will request a string review from l10n

  • If needed, I updated documentation and added comments to complex code

  • Fixes Suggestions view closes when attempting to scroll, when New Tab is set to Custom #28385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suggestions view closes when attempting to scroll, when New Tab is set to Custom

1 participant