Skip to content

BugFix FXIOS-28385 [Search Suggestions] Keep suggestions visible when scrolling on Custom New Tab #30144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+12 −0
Open

BugFix FXIOS-28385 [Search Suggestions] Keep suggestions visible when scrolling on Custom New Tab #30144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f563f7
Keep suggestions visible on scroll for Custom New Tab
ananyashreesharma Oct 23, 2025
e6bff74
Replacement of direct GleanMetrics calls with GleanWrapper API (Webvi…
ananyashreesharma Nov 18, 2025
a5d385f
Merge branch 'main' into fix/keep-suggestions-on-scroll
FilippoZazzeroni Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions firefox-ios/Client/Frontend/Browser/BrowserViewController/Views/BrowserViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4934,6 +4934,11 @@ extension BrowserViewController: KeyboardHelperDelegate {
}

private var shouldCancelEditing: Bool {
// Prevent closing suggestions when scrolling the suggestions list
if searchController != nil || overlayManager.inOverlayMode {
return false
}

let newTabChoice = NewTabAccessors.getNewTabPage(profile.prefs)
guard newTabChoice != .topSites, newTabChoice != .blankPage else { return false }

Expand Down
7 changes: 7 additions & 0 deletions firefox-ios/firefox-ios-tests/Tests/ClientTests/WebviewTelemetryTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,13 @@ class WebviewTelemetryTests: XCTestCase {

subject.start()
subject.cancel()
let savedMetric = try XCTUnwrap(
mockGleanWrapper.savedEvents.first as? TimingDistributionMetricType
)
XCTAssertEqual(mockGleanWrapper.startTimingCalled, 1)
XCTAssertEqual(mockGleanWrapper.cancelTimingCalled, 1)
XCTAssertEqual(mockGleanWrapper.stopAndAccumulateCalled, 0)
XCTAssert(savedMetric === metric, "Received \(savedMetric) instead of \(metric)")

let savedMetric = try XCTUnwrap(
mockGleanWrapper.savedEvents.first as? TimingDistributionMetricType
Expand Down