-
Notifications
You must be signed in to change notification settings - Fork 18
Support policies for VMs and fix a few issues #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Support policies for VMs and fix a few issues #316
Conversation
|
Many thanks to my colleague @johannwagner who helped with this work 😊 |
9040122 to
8ab427b
Compare
(for consistency with other NTC projects)
bcc2495 to
8ab427b
Compare
|
Following some testing, Seems like generated Aerleon Policies are not saved properly whenever an already existing one is updated. I have yet to check if it also happens upstream. Edit: issue is #321 |
11464f2 to
3d5e59c
Compare
|
Fixed in 3d5e59c |
- new m2m field - associated filter and serializer - migration
Co-authored-by: Johann Wagner <[email protected]>
746dab3 to
e529707
Compare
|
rebased following changes to #308 |
|
Hi @loulecrivain we've added this PR and #308 to our backlog and we're going to get them reviewed as soon as we can. |
Closes: #314 (and also #296, #315, #321)
Motivation for this PR: as explained in #314, some hypervisor platforms with integrated firewalls (Proxmox VE) now support setting firewall policies directly in front of Virtual Machines. We'd like to leverage Nautobot Firewall App capabilities in order to also be able to model this, and to directly generate firewall configuration from there.
What's Changed
New feature: attach virtual machines to policies
The user is now able to attach virtual machines to policies. Same also goes for NATPolicies. Here's a summary of the changes for this feature:
device_policies.htmltoobject_policies.html(now in common with VMs)0024)And some views:


New feature: support for generating AerleonPolicies for VirtualMachine
We modified the generation job logic to also be able to generate firewall configurations for Virtual Machines. The job form has also been changed to be able to select Virtual Machines and Devices for which the job should be carried.
Summary of changes:
0024. Forward and Backward migrartions have been tested with some generated AerleonPolicies for both VMs and Devices.Fix #296 generation with DynamicGroups
See previous screenshots for dynamic group attachment and generation without errors.
Summary of changes:
dyn.get_queryset()todyn.members.all().Fix #315 cannot search for Aerleon/Capirca Policies (q parameter not taken into account)
See screenshot below for working search.
Summary of changes:
To Do