-
-
Notifications
You must be signed in to change notification settings - Fork 707
refactor(language_server): remove ServerLinterDiagnostics
#15169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 10-30-refactor_language_server_backend_chekcs_the_correct_lintoptions_run_
Are you sure you want to change the base?
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the diagnostic storage mechanism in the ServerLinter by removing the intermediate ServerLinterDiagnostics wrapper struct and directly using Arc<ConcurrentHashMap> to store diagnostics.
- Removed the
ServerLinterDiagnosticsstruct and its associated methods - Simplified diagnostic access by directly interacting with the
ConcurrentHashMap - Removed the corresponding unit test that was testing the removed
ServerLinterDiagnosticsstruct
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2c84365 to
1547df2
Compare
1547df2 to
57f4002
Compare

Uh oh!
There was an error while loading. Please reload this page.