Skip to content

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Oct 30, 2025

This PR refactors the diagnostic storage mechanism in the ServerLinter by removing the intermediate ServerLinterDiagnostics wrapper struct and directly using Arc to store diagnostics.

@github-actions github-actions bot added A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 30, 2025
Copy link
Member Author

Sysix commented Oct 30, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the diagnostic storage mechanism in the ServerLinter by removing the intermediate ServerLinterDiagnostics wrapper struct and directly using Arc<ConcurrentHashMap> to store diagnostics.

  • Removed the ServerLinterDiagnostics struct and its associated methods
  • Simplified diagnostic access by directly interacting with the ConcurrentHashMap
  • Removed the corresponding unit test that was testing the removed ServerLinterDiagnostics struct

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Sysix Sysix force-pushed the 10-30-refactor_language_server_remove_serverlinterdiagnostics_ branch 2 times, most recently from 2c84365 to 1547df2 Compare October 31, 2025 10:47
@Sysix Sysix marked this pull request as ready for review October 31, 2025 11:06
@Sysix Sysix requested a review from camc314 as a code owner October 31, 2025 11:06
@Sysix Sysix force-pushed the 10-30-refactor_language_server_remove_serverlinterdiagnostics_ branch from 1547df2 to 57f4002 Compare October 31, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants