FIX: move ruff import rule to config so that pre-commit checks all project rules #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangkong
previously approved these changes
Jan 27, 2026
Contributor
tangkong
left a comment
tangkong
left a comment
There was a problem hiding this comment.
Whoops that's what I get for only working on projects with old pre-commit configs
Contributor
|
I think the ci here needs a bump to ubuntu latest, 20.04 was removed a while ago |
Member
Author
|
I'll bump it |
tangkong
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This
--select Icommand in the pre-commit config actually replaces our project's ruff options! So, pre-commit isn't running all of our configured rules!Instead, run ruff without
--selectto include all of our rules in the pyproject.toml, so they all get picked up during pre-commit. Then each project can decide which rules to follow as needed.On the side: I'm testing the N (pep8) and ANN (missing annotations) rulesets- if I end up thinking they are useful I'll make another PR here to make them our default, if they end up being annoying I will not.
Motivation and Context
I kept seeing PRs passing in
bsmtrajwhen they would failruffin my IDE, this is why.How Has This Been Tested?
Interactively only
Where Has This Been Documented?
Here only