Skip to content

FIX: move ruff import rule to config so that pre-commit checks all project rules #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZLLentz merged 2 commits into from
Jan 27, 2026
Merged

FIX: move ruff import rule to config so that pre-commit checks all project rules #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fe9089
FIX: move rule to config so that pre-commit checks all project rules
ZLLentz Jan 27, 2026
d5584a7
CI: use latest ubuntu instead of specific deprecated ubuntu
ZLLentz Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/cookiecutter-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ env:
jobs:
pip-test:
name: "Python 3.9: pip"
runs-on: ubuntu-20.04
runs-on: ubuntu-latest

defaults:
run:
Expand Down Expand Up @@ -122,7 +122,7 @@ jobs:

conda-test:
name: "Python 3.9: conda"
runs-on: ubuntu-20.04
runs-on: ubuntu-latest

defaults:
run:
Expand Down
2 changes: 1 addition & 1 deletion {{ cookiecutter.folder_name }}/.pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,6 @@ repos:
rev: v0.6.3
hooks:
- id: ruff # run the linter
args: [ --fix, --select, I ] # --select I sorts imports
args: [ --fix ] # and the safe fixes
- id: ruff-format # run the formatter

2 changes: 1 addition & 1 deletion {{ cookiecutter.folder_name }}/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ line-length = 88
exclude = [".git", "__pycache__", "build", "dist", "{{ cookiecutter.import_name }}/_version.py"]

[tool.ruff.lint]
select = ["C", "E", "F", "W", "B"]
select = ["C", "E", "F", "W", "B", "I"]

[tool.ruff.lint.pydocstyle]
convention = "numpy"