Skip to content

Conversation

@jeandemanged
Copy link
Member

@jeandemanged jeandemanged commented Oct 19, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

#3488

What kind of change does this PR introduce?

Feature

What is the current behavior?

DC Detailed model is introduced in #3439 in beta without SerDe support

What is the new behavior (if this is a feature change)?
IIDM SerDe supports DC detailed model. IIDM DC detailed model is not anymore beta starting IIDM v1.15.

Does this PR introduce a breaking change or deprecate an API?

  • Yes

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

  • TerminalRefSerDe.resolve(String id, ThreeSides side, Network network) takes an additional (nullable) TerminalNumber parameter, used to reference AcDcConverter AC terminals.
    • It is now TerminalRefSerDe.resolve(String id, ThreeSides side, TerminalNumber number, Network network).

Other information:

@jeandemanged jeandemanged linked an issue Oct 19, 2025 that may be closed by this pull request
@jeandemanged jeandemanged moved this from TODO to In Progress in Release 12/2025 Oct 19, 2025
@jeandemanged jeandemanged force-pushed the dc-detailled-serde branch 2 times, most recently from bbfb60c to 1e9ee06 Compare October 31, 2025 14:29
Base automatically changed from bump_iidm_to_1_15 to main November 6, 2025 09:21
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
Signed-off-by: Damien Jeandemange <[email protected]>
@jeandemanged jeandemanged changed the base branch from main to fix-acdcConverter-set-pccTerminal November 17, 2025 14:45
Base automatically changed from fix-acdcConverter-set-pccTerminal to main November 18, 2025 13:36
# Conflicts:
#	iidm/iidm-api/src/main/java/com/powsybl/iidm/network/ValidationUtil.java
#	iidm/iidm-tck/src/test/java/com/powsybl/iidm/network/tck/AbstractAcDcConverterTest.java
@sonarqubecloud
Copy link

@jeandemanged jeandemanged marked this pull request as ready for review November 27, 2025 10:27
@github-project-automation github-project-automation bot moved this from Waiting for review to Approved in Release 12/2025 Nov 27, 2025
@olperr1 olperr1 merged commit 12b8e08 into main Nov 27, 2025
9 checks passed
@olperr1 olperr1 deleted the dc-detailled-serde branch November 27, 2025 10:36
@github-project-automation github-project-automation bot moved this from Approved to Done in Release 12/2025 Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

DC detailed model IIDM SerDe

3 participants