-
Notifications
You must be signed in to change notification settings - Fork 23
Add version numbering to dev builds #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
| TAG=$(git describe --tags --match='v*' --abbrev=0 origin/master) | ||
|
|
||
| # If we're building in CircleCI, the version is "x.y.z+b<n>" where <n> is the | ||
| # If we're building in CircleCI, the version is "x.y.<b>" where <b> is the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why omit z here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our app/build.gradle expects versionNumber to be in the form <major>.<minor>.<patch>. If we want the build number to appear in both the versionString and versionCode, it has to go somewhere, and I figured replacing the <patch> number of the latest release was the most innocuous way to do that.
The alternative would be to continue to append the build number to the original versionNumber but then (a.) build.gradle would need to be updated to permit that and (b.) the versionCode wouldn't change between dev builds. (Maybe that's actually what we want?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, just to be clear on terminology, the fields are named versionName and versionCode.
The only practical effect of the versionCode is to prevent unintended downgrades. The Play Store will only perform automatic updates that increase the versionCode. As far as I know, only the Play Store enforces this; the phone doesn't care whether the vesionCode increases or not. Because we don't plan to ever publish development APKs to the Play Store, in some sense it doesn't matter what we use for dev builds.
Any of these choices are fine:
- Set
versionCodeto 0 for all dev builds - When
versionNameisx.y.z, setversionCodeto 1000000x + 10000y + z for all dev builds - When
versionNameisx.y.zat patchlevel p, setversionCodeto 1000000x + 10000y + 100z + p for all dev builds - When
versionNameisx.y.z, setversionCodeto 1000000x + 10000y + p for all dev builds
The first is the simplest (it's what build.gradle currently does, and I think it will work fine—the net effect is that any production release will supersede (automatically install over) any development release.
NOTE: This PR was doing too much and so I've split the CircleCI refactoring out into #406. This PR should be not be merged until after that one.
Issues:
Closes #401.
Scope:
Requested reviewers: @zestyping
User-visible changes
Both dev and release builds will have a version code and a human-readable version string.
Builds made from the command line will DTRT if the developer runs
./gradlew -DversionNumber=$(.circleci/get_package_version) assembleDebug.