Skip to content

DRY out the CircleCI configuration #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zestyping merged 2 commits into from
Aug 18, 2019
Merged

DRY out the CircleCI configuration #406

zestyping merged 2 commits into from
Aug 18, 2019

Conversation

@schuyler
Copy link
Member

@schuyler schuyler commented Jul 11, 2019

This PR has been split out from #402 for simplicity and clarity.

  • Refactor CircleCI configuration using YAML references to eliminate repeated stanzas. Note that this is inspired by what ODK Collect is doing.
  • Bump CircleCI build image to Android API 28, since that's what Gradle is using.

@schuyler schuyler requested a review from zestyping July 11, 2019 17:33
This was referenced Jul 11, 2019
Open
Open
zestyping
zestyping approved these changes Aug 18, 2019
View reviewed changes
Copy link
Contributor

@zestyping zestyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took me a while to get to this. I understand what's happening here now and it seems fine.

@zestyping zestyping merged commit a4a749e into dev Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zestyping zestyping zestyping approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@schuyler @zestyping