Refactor Landsat tests #3319
Open
Refactor Landsat tests #3319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Landsat tests work, but tests code is extremely complicated and almost unreadable. So, it is hard to add new tests
I tried to fully refactor Landsat tests to switch to class-based approach
Most of the functionality is now moved to base Landsat tests class
BaseLandsatTest, it includes creating file fixtures and most of the tests.Also, there are classes that include level-specific and sensor-specific tests and fixtures. These classes not only add the specific functionality, but also override the methods that exist in base class, but are not needed for this specific product (e.g. MSS test class override
thermal_bandfixture that is not needed here, but needed in all the other classes)The actual test classes are the classes that inherit from base class and specific classes. They include mostly setting the data variables that are unique for each test
This class-based approach will not only make tests more readable, but also will make it much easier to add new tests
This PR also fixes the error mentioned in #3300 and adds a specific test for MSS sensors that test wavelengths of a B4 band and one other band