Refactor Landsat tests #3319
Refactor Landsat tests #3319
CodeScene PR Check
Quality Gate Passed
(1 files improve in Code Health)
Gates Passed
See analysis details in CodeScene
View Improvements
| File | Code Health Impact | Categories Improved |
|---|---|---|
| test_landsat.py | 8.28 → 9.69 | Low Cohesion, Excess Number of Function Arguments |
Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
Details
✅ Improving Code Health:
- Excess Number of Function Arguments test_landsat.py: TestLandsat.test_basicload
- Excess Number of Function Arguments test_landsat.py: TestLandsat._check_basicload_thermal
- Excess Number of Function Arguments test_landsat.py: TestLandsat.test_ch_startend
- Excess Number of Function Arguments test_landsat.py: TestLandsat.test_loading_gd
- Excess Number of Function Arguments test_landsat.py: TestLandsat.test_loading_badfil
- Excess Number of Function Arguments test_landsat.py: TestLandsat.test_loading_badchan
- Excess Number of Function Arguments test_landsat.py: TestLandsat.test_badfiles
- Excess Number of Function Arguments test_landsat.py: TestLandsat.test_calibration_counts
- Excess Number of Function Arguments test_landsat.py: TestLandsat.test_calibration_radiance
- Excess Number of Function Arguments test_landsat.py: TestLandsat.test_calibration_highlevel
- Excess Number of Function Arguments test_landsat.py: TestLandsat._get_expected_highlevel_thermal
- Excess Number of Function Arguments test_landsat.py: TestLandsat._get_scn_highlevel
- Excess Number of Function Arguments test_landsat.py: TestLandsat.test_metadata
- Excess Number of Function Arguments test_landsat.py: TestLandsat.test_area_def
- Low Cohesion test_landsat.py
Annotations
Check notice on line 1 in satpy/tests/reader_tests/test_landsat.py
codescene-delta-analysis / CodeScene Code Health Review (main)
✅ No longer an issue: Low Cohesion
The number of different responsibilities in this module is no longer above the threshold
Check notice on line 442 in satpy/tests/reader_tests/test_landsat.py
codescene-delta-analysis / CodeScene Code Health Review (main)
✅ No longer an issue: Excess Number of Function Arguments
TestLandsat.test_basicload is no longer above the threshold for number of arguments. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Check notice on line 451 in satpy/tests/reader_tests/test_landsat.py
codescene-delta-analysis / CodeScene Code Health Review (main)
✅ No longer an issue: Excess Number of Function Arguments
TestLandsat._check_basicload_thermal is no longer above the threshold for number of arguments. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Check notice on line 457 in satpy/tests/reader_tests/test_landsat.py
codescene-delta-analysis / CodeScene Code Health Review (main)
✅ No longer an issue: Excess Number of Function Arguments
TestLandsat.test_ch_startend is no longer above the threshold for number of arguments. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Check notice on line 459 in satpy/tests/reader_tests/test_landsat.py
codescene-delta-analysis / CodeScene Code Health Review (main)
✅ No longer an issue: Excess Number of Function Arguments
TestLandsat.test_loading_gd is no longer above the threshold for number of arguments. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Check notice on line 462 in satpy/tests/reader_tests/test_landsat.py
codescene-delta-analysis / CodeScene Code Health Review (main)
✅ No longer an issue: Excess Number of Function Arguments
TestLandsat.test_loading_badfil is no longer above the threshold for number of arguments. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Check notice on line 475 in satpy/tests/reader_tests/test_landsat.py
codescene-delta-analysis / CodeScene Code Health Review (main)
✅ No longer an issue: Excess Number of Function Arguments
TestLandsat.test_loading_badchan is no longer above the threshold for number of arguments. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Check notice on line 496 in satpy/tests/reader_tests/test_landsat.py
codescene-delta-analysis / CodeScene Code Health Review (main)
✅ No longer an issue: Excess Number of Function Arguments
TestLandsat.test_badfiles is no longer above the threshold for number of arguments. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Check notice on line 497 in satpy/tests/reader_tests/test_landsat.py
codescene-delta-analysis / CodeScene Code Health Review (main)
✅ No longer an issue: Excess Number of Function Arguments
TestLandsat.test_calibration_counts is no longer above the threshold for number of arguments. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Check notice on line 501 in satpy/tests/reader_tests/test_landsat.py
codescene-delta-analysis / CodeScene Code Health Review (main)
✅ No longer an issue: Excess Number of Function Arguments
TestLandsat.test_calibration_radiance is no longer above the threshold for number of arguments. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Check notice on line 517 in satpy/tests/reader_tests/test_landsat.py
codescene-delta-analysis / CodeScene Code Health Review (main)
✅ No longer an issue: Excess Number of Function Arguments
TestLandsat.test_calibration_highlevel is no longer above the threshold for number of arguments. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Check notice on line 527 in satpy/tests/reader_tests/test_landsat.py
codescene-delta-analysis / CodeScene Code Health Review (main)
✅ No longer an issue: Excess Number of Function Arguments
TestLandsat._get_expected_highlevel_thermal is no longer above the threshold for number of arguments. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Check notice on line 529 in satpy/tests/reader_tests/test_landsat.py
codescene-delta-analysis / CodeScene Code Health Review (main)
✅ No longer an issue: Excess Number of Function Arguments
TestLandsat._get_scn_highlevel is no longer above the threshold for number of arguments. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Check notice on line 741 in satpy/tests/reader_tests/test_landsat.py
codescene-delta-analysis / CodeScene Code Health Review (main)
✅ No longer an issue: Excess Number of Function Arguments
TestLandsat.test_metadata is no longer above the threshold for number of arguments. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Check notice on line 858 in satpy/tests/reader_tests/test_landsat.py
codescene-delta-analysis / CodeScene Code Health Review (main)
✅ No longer an issue: Excess Number of Function Arguments
TestLandsat.test_area_def is no longer above the threshold for number of arguments. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.