fix: Reject unsupported DSSE version #1063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronlew02
force-pushed
the
dsse-version-fix
branch
2 times, most recently
from
69f32cf to
7fb2336
Compare
loosebazooka
reviewed
Sep 5, 2025
aaronlew02
force-pushed
the
dsse-version-fix
branch
from
7fb2336 to
c861d1a
Compare
loosebazooka
previously approved these changes
Sep 5, 2025
aaronlew02
force-pushed
the
dsse-version-fix
branch
from
c861d1a to
c146729
Compare
|
this PR seems to have a weird commit state actually, might be worth doing a clean rebase |
Signed-off-by: Aaron Lew <[email protected]>
aaronlew02
force-pushed
the
dsse-version-fix
branch
from
c146729 to
36b9486
Compare
loosebazooka
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change adds an exception that is thrown when the version of a DSSE envelope in a Rekor entry is unsupported.