Support multipart upload when image_size == 0#7
Closed
priteau wants to merge 1 commit intostackhpc/2024.1from
Closed
Support multipart upload when image_size == 0#7priteau wants to merge 1 commit intostackhpc/2024.1from
priteau wants to merge 1 commit intostackhpc/2024.1from
Conversation
When doing an image upload of a volume from cinder-volume to glance with an s3 backend, image_size in this context is zero. As a result the check that image_size is larger than s3_store_large_object_size is always negative and glance_store never uses multipart upload. As a workaround, allow setting s3_store_large_object_size to 0, which forces glance_store to use multipart upload. Related-Bug: #2043740 Change-Id: I436d56d0489b081822ed55108e10d43cc38512bb (cherry picked from commit e63e0e4)
|
Duplicate of: #6 |
Member
Author
|
Duplicate of #6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When doing an image upload of a volume from cinder-volume to glance with an s3 backend, image_size in this context is zero. As a result the check that image_size is larger than s3_store_large_object_size is always negative and glance_store never uses multipart upload.
As a workaround, allow setting s3_store_large_object_size to 0, which forces glance_store to use multipart upload.
Related-Bug: #2043740
Change-Id: I436d56d0489b081822ed55108e10d43cc38512bb (cherry picked from commit e63e0e4)