Skip to content

Support multipart upload when image_size == 0 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
priteau wants to merge 1 commit into from
Closed

Support multipart upload when image_size == 0 #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion glance_store/_drivers/s3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@
"""),
cfg.IntOpt('s3_store_large_object_size',
default=DEFAULT_LARGE_OBJECT_SIZE,
min=0,
help="""
What size, in MB, should S3 start chunking image files and do a multipart
upload in S3.
Expand All @@ -190,7 +191,7 @@
Note: You can only split up to 10,000 images.

Possible values:
* Any positive integer value
* Any positive integer value or zero

Related Options:
* s3_store_large_object_chunk_size
Expand Down Expand Up @@ -473,6 +474,8 @@ def _option_get(self, param):
if not result:
if param == 's3_store_create_bucket_on_put':
return result
if param == 's3_store_large_object_size':
return result
if param == 's3_store_region_name':
return result
if param == 's3_store_cacert':
Expand Down
10 changes: 10 additions & 0 deletions releasenotes/notes/s3-store-large-object-size-zero-a24229ae6955b799.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
features:
- |
Support setting ``s3_store_large_object_size`` to ``0`` to force multipart
upload when ``image_size`` is unknown.
fixes:
- |
`Bug #2043740 <https://bugs.launchpad.net/glance-store/+bug/2043740>`_:
``s3_store_large_object_size`` can be set to ``0`` to force multipart
upload when creating an image in the S3 backend from a Cinder volume.
Loading