starknet_patricia_storage: rocksDB stats

[nimrod-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[nimrod-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• starknet_patricia_storage: use index DB for benchmarks #11877
• starknet_patricia_storage: rocksDB stats #11876 👈 (View in Graphite)
• starknet_patricia_storage: save options #11875
• starknet_patricia_storage: tune rocksDB config #11874
• starknet_patricia_storage: dont use wal for rocksdb #11869
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ArielElp]

@ArielElp reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware).

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages, and made 3 comments.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @nimrod-starkware).

---

crates/starknet_patricia_storage/src/rocksdb_storage.rs line 83 at r2 (raw file):

        // Enable statistics collection.
        opts.enable_statistics();
        opts.set_statistics_level(StatsLevel::ExceptDetailedTimers);

it's ok that this is the default but in production we will need to control this - stat collection can slow things down, we need to be able to turn it off

Code quote:

        // Enable statistics collection.
        opts.enable_statistics();
        opts.set_statistics_level(StatsLevel::ExceptDetailedTimers);

---

crates/starknet_patricia_storage/src/rocksdb_storage.rs line 175 at r2 (raw file):

            self.options
                .db_options
                .get_statistics()

what is the format of this...?
if it's a comma-separated value string, can you parse it?

Code quote:

.get_statistics()

---

crates/starknet_patricia_storage/src/rocksdb_storage.rs line 176 at r2 (raw file):

                .db_options
                .get_statistics()
                .expect("Statistics are unexpectedly disabled."),

return an Err here please - we don't want potential panic locations in production code, when all this does is collect stats

Code quote:

.expect("Statistics are unexpectedly disabled."),