starknet_patricia_storage: use index DB for benchmarks

[nimrod-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[nimrod-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• starknet_patricia_storage: use index DB for benchmarks #11877 👈 (View in Graphite)
• starknet_patricia_storage: rocksDB stats #11876
• starknet_patricia_storage: save options #11875
• starknet_patricia_storage: tune rocksDB config #11874
• starknet_patricia_storage: dont use wal for rocksdb #11869
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ArielElp]

@ArielElp reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware).

---

crates/starknet_committer/src/db/index_db/db.rs line 38 at r1 (raw file):

pub struct IndexDb<S: Storage> {
    pub storage: S,

Dori preferred not to give arbitrary access to the forest storage. Maybe we should add a get_storage_for_testing function?

[nimrod-starkware]

@nimrod-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArielElp).

---

crates/starknet_committer/src/db/index_db/db.rs line 38 at r1 (raw file):

Previously, ArielElp wrote…

Dori preferred not to give arbitrary access to the forest storage. Maybe we should add a get_storage_for_testing function?

Done

[ArielElp]

@ArielElp reviewed 2 files and resolved 1 discussion.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @nimrod-starkware).

[ArielElp]

@ArielElp made 1 comment.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @nimrod-starkware).

[dorimedini-starkware]

@dorimedini-starkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware).

---

crates/starknet_committer/src/db/index_db/db.rs line 54 at r2 (raw file):

    pub fn get_mut_storage(&mut self) -> &mut S {
        &mut self.storage
    }

consider

1. implementing get_stats and reset_stats, no need for the feature
2. behind the feature flag, get_async_underlying_storage
   non-blocking

Code quote:

    #[cfg(any(feature = "testing", test))]
    pub fn get_storage(&self) -> &S {
        &self.storage
    }

    #[cfg(any(feature = "testing", test))]
    pub fn get_mut_storage(&mut self) -> &mut S {
        &mut self.storage
    }

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware).

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware).