feat: support criterion 0.7 #277
Open
+466
−357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @xu-cheng! It looks like this is your first PR to tikv/pprof-rs 🎉 |
Update MSRV to 1.80 as it is required by criterion 0.7. Signed-off-by: Cheng Xu <[email protected]>
|
@YangKeao Would you be able to review this one? Shouldn't be too rough. |
|
I am wondering if there's anything that I can do to help get this merged? It seems quite simple, but maybe there are reasons why moving to criterion 0.7 might be a problem for some? |
|
@mjgarton I resolved the issue by going to ~25 repos, and changing the instructions for people to use Half a year, a few PRs, and not even a word from the maintainers- who are active here- even after pinging. Similar for other issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update MSRV to 1.80 as it is required by criterion 0.7.