Check btest.cfg for Python configparser interpolation errors #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a pass over the (non-default) config options in the freshly loaded configparser, catching any interpolation errors and reporting them in our own terms. This has some subtlety since we cannot just check all config options, due to configparser's built-in default-fallback behavior: since we pull os.environ into the defaults, checking everything is brittle since there may well be some environment variables that aren't formatted for Python interpolation (as, in my case, HISTTIMEFORMAT).
Member
Author
|
Btw — I am not sure whether we should still be patching |
bbannier
approved these changes
Oct 2, 2025
awelzel
added a commit
that referenced
this pull request
Dec 10, 2025
In #122 there's spurious stderr output for Spicy's test suite reported. This is due to the new code from #121 eagerly reading all keys in all sections, even if some, like [environment-<tag>] sections for alternatives, would never be used if not selected explicitly. Move the interpolation check below Options.alternative wrangling and skip sections that won't be used. This squelches the spurious stderr output. I've added a test, though it's a bit opaque.
awelzel
added a commit
that referenced
this pull request
Dec 10, 2025
In #122 there's spurious stderr output for Spicy's test suite reported. This is due to the new code from #121 eagerly reading all keys in all sections, even if some, like [environment-<tag>] sections for alternatives, would never be used if not selected explicitly. Move the interpolation check below Options.alternative wrangling and skip sections that won't be used. This squelches the spurious stderr output. I've added a test, though it's a bit opaque.
awelzel
added a commit
that referenced
this pull request
Dec 16, 2025
In #122 there's spurious stderr output for Spicy's test suite reported. This is due to the new code from #121 eagerly reading all keys in all sections, even if some, like [environment-<tag>] sections for alternatives, would never be used if not selected explicitly. Move the interpolation check below Options.alternative wrangling and skip sections that won't be used. This squelches the spurious stderr output. I've added a test, though it's a bit opaque.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a pass over the (non-default) config options in the freshly loaded configparser, catching any interpolation errors and reporting them in our own terms. This has some subtlety since we cannot just check all config options due to configparser's built-in default-fallback behavior. Since btest pulls os.environ into the defaults, checking everything may well trip over some environment variables that aren't formatted for Python interpolation (as, in my case, HISTTIMEFORMAT).
This is a follow-up to #119 because regardless of whether or not we find the default Python error message intuitive, I think crashing out with a backtrace is excessive.
Resolves #119.