-
Notifications
You must be signed in to change notification settings - Fork 4
Switch PEAR dependency to github #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| "repositories": [ | ||
| { | ||
| "type": "pear", | ||
| "url": "https://pear.php.net" | ||
| } | ||
| ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me get this straight, specifying this repository no longer works in composer v2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I remember. It's been a long time. But I don't think this PR is really necessary, since it's specified in https://github.com/zf1s/phpunit/blob/master/.github/workflows/tests.yml#L52 to use composer v1, just offload the testing to github, why would you even want to run tests locally 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@falkenhawk there have been too many issues to test it via github each time, new way works both in v1 and v2, so it's an improvement. It's about this issue:
composer/composer#8778
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yet it doesn't work on php 5.3, only the pear.php.net version is compatible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@falkenhawk ok let it stay then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a bit cumbersome, but locally installed composer can be switched to v1 and back to v2 with composer self-update --1, composer self-update --2
Fix for composer error:
"The PEAR repository has been removed from Composer 2.x"