Skip to content

Switch PEAR dependency to github #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Switch PEAR dependency to github #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,6 @@
"support": {
"issues": "https://github.com/zf1s/phpunit/issues"
},
"repositories": [
{
"type": "pear",
"url": "https://pear.php.net"
}
],
Comment on lines -28 to -33
Copy link
Member

@falkenhawk falkenhawk Apr 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me get this straight, specifying this repository no longer works in composer v2?

Copy link
Member

@falkenhawk falkenhawk Apr 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I remember. It's been a long time. But I don't think this PR is really necessary, since it's specified in https://github.com/zf1s/phpunit/blob/master/.github/workflows/tests.yml#L52 to use composer v1, just offload the testing to github, why would you even want to run tests locally 😅

Copy link
Collaborator Author

@marcing marcing Apr 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@falkenhawk there have been too many issues to test it via github each time, new way works both in v1 and v2, so it's an improvement. It's about this issue:
composer/composer#8778

Copy link
Member

@falkenhawk falkenhawk Apr 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yet it doesn't work on php 5.3, only the pear.php.net version is compatible

Copy link
Collaborator Author

@marcing marcing Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@falkenhawk ok let it stay then.

Copy link
Member

@falkenhawk falkenhawk Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a bit cumbersome, but locally installed composer can be switched to v1 and back to v2 with composer self-update --1, composer self-update --2

"require": {
"php": ">=5.3.3",
"phpunit/php-text-template": "^1.2.1",
Expand All @@ -47,7 +41,7 @@
"ext-spl": "*"
},
"require-dev": {
"pear-pear.php.net/pear": "~1.9|~1.10"
"pear/pear": "^1.10"
},
"suggest": {
"phpunit/php-invoker": "~1.1"
Expand Down
Loading