-
Notifications
You must be signed in to change notification settings - Fork 2
Added Interrupted status to transaction entity #434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying happychain with
|
| Latest commit: |
caa054f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3c8eb51d.happychain.pages.dev |
| Branch Preview URL: | https://gabriel-transaction-reorder.happychain.pages.dev |
HAPPY-365 TXM: Handle cases where the nonce moved past an intent but all our attemps are not included
Probably add new status, something like TRANSACTION_REORDER. The tx can then re-enqueue it from an originator if need be. The downside is we can have the tx "cut in line" — but because we already assigned nonces and probably submitted the other txs in the queue, this would require implementing nonce renumbering, which is bound to be extremely messy and complex. This should never happen anyway — in theory it only happens if the submitter key is used concurrently somewhere else. |
0add1f7 to
e2f7e3e
Compare
44e3f25 to
4e2c3a5
Compare
e2f7e3e to
db160d2
Compare
4e2c3a5 to
09281ca
Compare
c57ca4e to
ff8bd52
Compare
52b0968 to
23723dd
Compare
0f06207 to
073aefb
Compare
4f3b431 to
dabb31d
Compare
926f11e to
734d609
Compare
734d609 to
6c325df
Compare
52ba575 to
caa054f
Compare

Linked Issues
Description
This PR addresses the problem we were experiencing in production, where there was a nonce that had been used, but we did not have the corresponding attempt recorded in our system. This was causing infinite retries or cancellations if the transaction had a deadline.
Now, we have implemented a new status, Interrupted, where transactions meeting this criteria are moved. The user can decide to include the transaction again by sending it through the originator function.
Toggle Checklist
Checklist
Basics
norswap/build-system-caching).Reminder: PR review guidelines
Correctness
testnet, mainnet, standalone wallet, ...).
< INDICATE BROWSER, DEMO APP & OTHER ENV DETAILS USED FOR TESTING HERE >
< INDICATE TESTED SCENARIOS (USER INTERFACE INTERACTION, CODE FLOWS) HERE >
and have updated the code & comments accordingly.
Architecture & Documentation
(2) commenting these boundaries correctly, (3) adding inline comments for context when needed.
comments.
in a Markdown document.
pacakges/coreandpackages/react), see here for more info.