Skip to content

Conversation

@GabrielMartinezRodriguez
Copy link
Contributor

@GabrielMartinezRodriguez GabrielMartinezRodriguez commented Jan 22, 2025

Linked Issues

Description

The default timeout is now 500ms, which is too low if you need to simulate a transaction to measure the gas limit

Toggle Checklist

Checklist

Basics

  • B1. I have applied the proper label & proper branch name (e.g. norswap/build-system-caching).
  • B2. This PR is not so big that it should be split & addresses only one concern.
  • B3. The PR targets the lowest branch it can (ideally master).

Reminder: PR review guidelines

Correctness

  • C1. Builds and passes tests.

  • C2. The code is properly parameterized & compatible with different environments (e.g. local,
    testnet, mainnet, standalone wallet, ...).

  • C3. I have manually tested my changes & connected features.

  • C4. I have performed a thorough self-review of my code after submitting the PR,
    and have updated the code & comments accordingly.

Architecture & Documentation

  • D1. I made it easy to reason locally about the code, by (1) using proper abstraction boundaries,
    (2) commenting these boundaries correctly, (3) adding inline comments for context when needed.
  • D2. All public-facing APIs & meaningful (non-local) internal APIs are properly documented in code
    comments.
  • D3. If appropriate, the general architecture of the code is documented in a code comment or
    in a Markdown document.

@GabrielMartinezRodriguez GabrielMartinezRodriguez marked this pull request as ready for review January 22, 2025 15:07
@GabrielMartinezRodriguez GabrielMartinezRodriguez added the reviewing-1 Ready for, or undergoing first-line review label Jan 22, 2025
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 22, 2025

Deploying happychain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4722d38
Status: ✅  Deploy successful!
Preview URL: https://bdd92e7b.happychain.pages.dev
Branch Preview URL: https://gabriel-txm-increase-timeout.happychain.pages.dev

View logs

@linear
Copy link

linear bot commented Jan 22, 2025

HAPPY-308 Increase the default timeout to allow the gas estimator to spend more time

The default timeout is now 500ms, which is too low if you need to simulate a transaction to measure the gas limit

@GabrielMartinezRodriguez GabrielMartinezRodriguez changed the title feat: increase default RPC timeout to 2000ms Increase default RPC timeout to 2000ms Jan 22, 2025
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/txm-http-polling-interval branch from 0b937a8 to 9fa6f10 Compare January 31, 2025 14:44
@GabrielMartinezRodriguez GabrielMartinezRodriguez mentioned this pull request Feb 3, 2025
10 tasks
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/txm-http-polling-interval branch from 9fa6f10 to 9cee1b9 Compare February 3, 2025 12:40
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/txm-http-polling-interval branch from 9cee1b9 to 61a2966 Compare February 3, 2025 13:14
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/txm-http-polling-interval branch from 61a2966 to 6655ac3 Compare February 4, 2025 13:51
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/txm-http-polling-interval branch from 6655ac3 to 991bf7f Compare February 5, 2025 14:03
Base automatically changed from gabriel/txm-http-polling-interval to gabriel/txm-force-initialization February 5, 2025 16:07
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/txm-force-initialization branch 6 times, most recently from 0c3569a to 0e8184e Compare February 10, 2025 18:58
@aodhgan aodhgan force-pushed the gabriel/txm-force-initialization branch from 11296ce to 2e6b4ea Compare February 10, 2025 20:12
Base automatically changed from gabriel/txm-force-initialization to master February 10, 2025 20:17
@norswap norswap force-pushed the gabriel/txm-increase-timeout branch from 877ca68 to fab80c3 Compare February 10, 2025 20:23
@aodhgan aodhgan merged commit 5d6608a into master Feb 10, 2025
3 checks passed
@aodhgan aodhgan deleted the gabriel/txm-increase-timeout branch February 10, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-blocked Ready to merge, waiting for downstack

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants