Skip to content

Conversation

@GabrielMartinezRodriguez
Copy link
Contributor

@GabrielMartinezRodriguez GabrielMartinezRodriguez commented Dec 27, 2024

Linked Issues

The monitoring script provides real-time verification of:

  • Contract random values against expected drand beacon values
  • Block-specific revealed values
  • Timestamp to round conversion accuracy
Toggle Checklist

Checklist

Basics

  • B1. I have applied the proper label & proper branch name (e.g. norswap/build-system-caching).
  • B2. This PR is not so big that it should be split & addresses only one concern.
  • B3. The PR targets the lowest branch it can (ideally master).

Correctness

  • C1. Builds and passes tests.

  • C2. The code is properly parameterized & compatible with different environments (e.g. local, testnet, mainnet, standalone wallet, ...).

  • C3. I have manually tested my changes & connected features.

  • C4. I have performed a thorough self-review of my code after submitting the PR, and have updated the code & comments accordingly.

Architecture & Documentation

  • D1. I made it easy to reason locally about the code, by (1) using proper abstraction boundaries, (2) commenting these boundaries correctly, (3) adding inline comments for context when needed.
  • D2. All public-facing APIs & meaningful (non-local) internal APIs are properly documented in code comments.
  • D3. If appropriate, the general architecture of the code is documented in a code comment or in a Markdown document.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Dec 27, 2024

Deploying happychain with  Cloudflare Pages  Cloudflare Pages

Latest commit: ab4f347
Status: ✅  Deploy successful!
Preview URL: https://a5dc9ea2.happychain.pages.dev
Branch Preview URL: https://gabriel-randomnness-monitor.happychain.pages.dev

View logs

@GabrielMartinezRodriguez GabrielMartinezRodriguez changed the title Fix drand round calculation Script to monitor randomness service Dec 27, 2024
@linear
Copy link

linear bot commented Dec 27, 2024

@GabrielMartinezRodriguez GabrielMartinezRodriguez marked this pull request as ready for review December 27, 2024 12:12
@norswap norswap added the draft Not ready for review label Jan 2, 2025
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/randomness-local-script branch from 490511a to 6cf351c Compare January 6, 2025 16:01
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/randomness-local-script branch from 6cf351c to 9d42396 Compare January 7, 2025 09:53
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/randomness-local-script branch 2 times, most recently from bf939af to d329cc7 Compare January 13, 2025 13:23
@GabrielMartinezRodriguez GabrielMartinezRodriguez added reviewing-1 Ready for, or undergoing first-line review and removed draft Not ready for review labels Jan 21, 2025
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/randomness-local-script branch from d329cc7 to b0bcc07 Compare January 22, 2025 11:42
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/randomness-local-script branch from b0bcc07 to 7446669 Compare January 22, 2025 13:46
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/randomness-local-script branch from 7446669 to 9ed42c1 Compare January 22, 2025 14:18
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/randomness-local-script branch from aefc9c6 to abbe323 Compare February 10, 2025 18:40
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/randomnness-monitor branch 3 times, most recently from 7d22163 to b9d86aa Compare February 10, 2025 18:58
Base automatically changed from gabriel/randomness-local-script to master February 10, 2025 19:03
@aodhgan aodhgan force-pushed the gabriel/randomnness-monitor branch from 63f2f41 to 72d43d6 Compare February 10, 2025 19:25
@aodhgan aodhgan force-pushed the gabriel/randomnness-monitor branch from 72d43d6 to ab4f347 Compare February 10, 2025 19:33
@aodhgan aodhgan merged commit 3ef92b1 into master Feb 10, 2025
3 checks passed
@aodhgan aodhgan deleted the gabriel/randomnness-monitor branch February 10, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviewing-2 Ready for, or undergoing final review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants