fix(deps)!: upgrade rimraf addressing upstream warnings #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves deprecation warnings about glob, inflight, and rimraf. See istanbuljs/nyc#1563.
bcoe
requested changes
May 2, 2025
There was a problem hiding this comment.
This version of rimraf requires Node 14 or higher I believe? So this is a breaking change. Not necessarily a problem, but we will need to be careful about landing.
Update the PR title to:
fix(deps)!: upgrade rimraf addressing upstream warnings
If you don't mind 👏
anomiex
changed the title
I dont't mind at all. 🙂 |
bcoe
reviewed
May 7, 2025
| "istanbul-lib-coverage": "^3.2.0", | ||
| "p-map": "^3.0.0", | ||
| "rimraf": "^3.0.0", | ||
| "rimraf": "^4.0.0", |
There was a problem hiding this comment.
Sorry for the slow turnaround on this review, if you don't mind also add this to package.json:
"engines": {
"node": ">=14"
},
I can take it from there.
|
Done, thanks! |
anomiex
added a commit
to anomiex/spawn-wrap
that referenced
this pull request
May 7, 2025
Matching request at istanbuljs/istanbul-lib-processinfo#26 (comment)
anomiex
added a commit
to anomiex/spawn-wrap
that referenced
this pull request
May 7, 2025
Matching request at istanbuljs/istanbul-lib-processinfo#26 (comment)
|
Hi, is there any progress on this PR? I'm receiving 8 lines of deprecation warnings in each clean |
|
@bcoe Is there anything else you need from me to move forward on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves deprecation warnings about glob, inflight, and rimraf. See istanbuljs/nyc#1563.