one torch dataset & target data schema #375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfulu
reviewed
Nov 14, 2025
dfulu
reviewed
Nov 14, 2025
dfulu
reviewed
Nov 14, 2025
dfulu
reviewed
Nov 14, 2025
dfulu
reviewed
Nov 14, 2025
| location_id: id for location | ||
| """ | ||
| # Check the user has asked for a sample which we have the data for | ||
| if t0 not in self.valid_t0_times or self.valid_t0_and_location_ids: |
Member
There was a problem hiding this comment.
I think this might need a little more care. If self.complete_generation==True we can check for t0 in self.complete_generation but I think for self.complete_generation==False we should really check if the pair (t0, location_id) is in self.valid_t0_and_location_ids.
Member
Author
There was a problem hiding this comment.
Yep that's fair, I've added a stronger check now
dfulu
reviewed
Nov 14, 2025
dfulu
reviewed
Nov 14, 2025
dfulu
reviewed
Nov 14, 2025
dfulu
reviewed
Nov 14, 2025
dfulu
reviewed
Nov 14, 2025
Member
Author
|
Thanks for taking a look at this @dfulu, I have addressed all the comments now so hopefully this is good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Changes to support one torch dataset/input data schema this is a development branch which has had two major commits into it which were already reviewed, those were:
Fixes #334
How Has This Been Tested?
Through unit tests and also running training with the new changes