Skip to content

Conversation

@GabrielMartinezRodriguez
Copy link
Contributor

Linked Issues

  • closes #XXX
  • closes

Description

< DESCRIPTION GOES HERE >

  • Include all relevant context (but no need to repeat the issue's content).
  • Draw attention to new, noteworthy & unintuitive elements.
Toggle Checklist

Checklist

Basics

  • B1. I have applied the proper label & proper branch name (e.g. norswap/build-system-caching).
  • B2. This PR is not so big that it should be split & addresses only one concern.
  • B3. The PR targets the lowest branch it can (ideally master).

Reminder: PR review guidelines

Correctness

  • C1. Builds and passes tests.
  • C2. The code is properly parameterized & compatible with different environments (e.g. local,
    testnet, mainnet, standalone wallet, ...).
  • C3. I have manually tested my changes & connected features.

< INDICATE BROWSER, DEMO APP & OTHER ENV DETAILS USED FOR TESTING HERE >

< INDICATE TESTED SCENARIOS (USER INTERFACE INTERACTION, CODE FLOWS) HERE >

  • C4. I have performed a thorough self-review of my code after submitting the PR,
    and have updated the code & comments accordingly.

Architecture & Documentation

  • D1. I made it easy to reason locally about the code, by (1) using proper abstraction boundaries,
    (2) commenting these boundaries correctly, (3) adding inline comments for context when needed.
  • D2. All public-facing APIs & meaningful (non-local) internal APIs are properly documented in code
    comments.
  • D3. If appropriate, the general architecture of the code is documented in a code comment or
    in a Markdown document.
  • D4. An appropriate Changeset has been generated (and committed) for changes that touch npm published packages (currently pacakges/core and packages/react), see here for more info.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 12, 2025

Deploying happychain with  Cloudflare Pages  Cloudflare Pages

Latest commit: f5032b5
Status: ✅  Deploy successful!
Preview URL: https://67c56968.happychain.pages.dev
Branch Preview URL: https://gabriel-debug-randomness.happychain.pages.dev

View logs

Copy link
Contributor Author

GabrielMartinezRodriguez commented Feb 12, 2025

@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/debug-randomness branch 2 times, most recently from 4dc8d4b to 2d00065 Compare February 14, 2025 13:01
@norswap norswap added the no-merge For showcase, not to be merged label Feb 15, 2025
@norswap
Copy link
Collaborator

norswap commented Feb 15, 2025

Marking this as no-merge as I think it's just for a deploy? If it's actually intended to be a merged PR feel free to change to draft tag.

And don't forget to close if/when this isn't needed anymore.

@aodhgan
Copy link
Contributor

aodhgan commented Feb 18, 2025

think we are ok to close this one @GabrielMartinezRodriguez ? work has been rolled into other PR's

@norswap norswap deleted the gabriel/debug-randomness branch July 24, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-merge For showcase, not to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants